Lax deps #17
Open
Lax deps #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ceda_moles_django because of elasticsearch version requirement conflict)
|
I spoke to @spepler. He believes that the requirement on elasticsearch is likely to be a genuine one -- suggesting that more work is needed than simply changing the requirements file. (This differs from @djspstfc's assessment of the situation, mentioned above.) If so, then probably not appropriate to merge this PR in its current form -- even aside from the fact that the CI checks are failing, probably because of something Poetry related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing version dependencies that are constraining -- e.g. says that it requires elasticsearch 7, which prevents co-installation with MOLES (which wants 8), even though @djspstfc says that it doesn't really require 7.