Update to README and other small changes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
README.md
Big update to README.md, each of the options in
checksit checkhave initial description with example of how to use, as in Issue #14.The other three options for
checksithave a basic description that can be flushed out as that functionality is increased.requirements.txt
Addition of
pandasrequirement, as it is used inchecksit summary, as mentioned in Issue #13.checksit/generic.py
Within
check_global_attrs, actually looks at global attributes withindctrather than just the top level, which was global attributes, variables and dimensions (I think). This meant that when checking a global attribute exists or its vocabs, the attribute was not being found due to the code looking in the wrong place.