Align draft with POC for multiproof changes #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertpl
commented
Oct 24, 2023
albertpl
force-pushed
the
draft-prio3-multiproof
branch
from
f413443 to
865ec0a
Compare
cjpatton
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Great start! I still need to double check that the reference code was copied properly (will do so in my next pass). In the meantime, the text needs a little work:
- I think we need a gentler introduction to the idea of multiple proofs. In the overview section, I think we should start by describing things in terms of a single proof, then have a paragraph where we describe the multi-proof feature and, just as importantly, why we need it
- Terms like "proofs share" and "verifiers share" make sense as variable names in code, but they don't read very well in English. My advice would be to read through the Prio3.
- We're going to need a section in Security Considerations about how changing
PROOFSimpacts security, in particular when we go for a smaller field for a given circuit. Feel free to leave as a TODO for now, but we should at least stub it out so we remember to get to it later.
albertpl
commented
Oct 27, 2023
albertpl
force-pushed
the
draft-prio3-multiproof
branch
from
3a5a21c to
6572a2b
Compare
cjpatton
reviewed
Oct 30, 2023
draft-irtf-cfrg-vdaf.md
Outdated
| @@ -4561,6 +4621,10 @@ We also stress that even if the Idpf is not extractable, Poplar1 guarantees | |||
| that every client can contribute to at most one prefix among the ones being | |||
| evaluated by the helpers. | |||
|
|
|||
| ## Considerations for multiple proofs (`PROOFS`) {#security-multiproof} | |||
There was a problem hiding this comment.
Add a newline between the title and the first paragraph
Suggested change
| ## Considerations for multiple proofs (`PROOFS`) {#security-multiproof} | |
| ## Considerations for multiple proofs (`PROOFS`) {#security-multiproof} | |
draft-irtf-cfrg-vdaf.md
Outdated
| @@ -4561,6 +4621,10 @@ We also stress that even if the Idpf is not extractable, Poplar1 guarantees | |||
| that every client can contribute to at most one prefix among the ones being | |||
| evaluated by the helpers. | |||
|
|
|||
| ## Considerations for multiple proofs (`PROOFS`) {#security-multiproof} | |||
| > TODO on how changing `PROOFS` ({{multiproofs}}) impacts security, in particular when we go | |||
There was a problem hiding this comment.
- "TODO"s should be imperative, similarly to how we write commit messages. (E.g., TODO Add guidance for ..."
- Add a reference to the open issue.
- Break lines at 80 characters.
albertpl
force-pushed
the
draft-prio3-multiproof
branch
from
7ece83c to
f1e0533
Compare
cjpatton
reviewed
Nov 2, 2023
cjpatton
approved these changes
Nov 2, 2023
albertpl
force-pushed
the
draft-prio3-multiproof
branch
from
d8fc8fe to
974e24c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update draft per multiproof POC
Prio3.PROOFS