Prio3: Improve circuit specifications #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewer note: the diff is quite big because we are coalescing the circuit specification, encoding scheme, and parameter table into a single listing. My recommendation would be not look at the diff, but instead pull the branch and read through {{prio3-instantiations}}. |
cjpatton
commented
Oct 8, 2024
cjpatton
force-pushed
the
cjpatton/412
branch
2 times, most recently
from
d4541cc to
f7dd19a
Compare
cjpatton
force-pushed
the
cjpatton/411
branch
2 times, most recently
from
c8e6146 to
7473dd3
Compare
|
Rebased. |
|
Rebased. Initially the unit tests failed because |
|
Rebased. |
divergentdave
approved these changes
Oct 10, 2024
Rework the spec of each Prio3 variant by listing the entire class of each circuit. Also, list the specification of each gadget in the appendix. * Prio3Sum: Use `PolyEval` instead of `Range2`, as this is a much more useful gadget to list in the doc. * Say "variant" instead of "instance". * Document missing operations on polynomials. * Modify the constructor for `Field` elements by interpreting negative integers as additive inverses. This is necessary in order to allow expressing polynomial coefficients in the `PolyEval` circuit independent of the field modulus.
cjpatton
force-pushed
the
cjpatton/411
branch
from
5dab644 to
517034b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #449 (to reduce rebase conflicts later on).
Closes #411.
Rework the spec of each Prio3 variant by listing the entire class of each circuit. Also, list the specification of each gadget in
the appendix.
PolyEvalinstead ofRange2, as this is a much more useful gadget to list in the doc.Fieldelements by interpreting negative integers as additive inverses. This is necessary in order to allow expressing polynomial coefficients in thePolyEvalcircuit independent of the field modulus.