Replace aggregate() with streaming API
#452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewer note: So far I've just modified the reference code. If folks are happy with this approach, then I'll propagate to the doc. |
cjpatton
force-pushed
the
cjpatton/432
branch
4 times, most recently
from
616046a to
c21702e
Compare
branlwyd
reviewed
Oct 8, 2024
branlwyd
approved these changes
Oct 8, 2024
|
Rebased and squashed @branlwyd's feedback. |
divergentdave
approved these changes
Oct 9, 2024
Modify both `Daf` and `Vdaf` by replacing `aggregate()` with two methods: * `agg_init()` returns an empty aggregate share * `agg_update()` updates an aggregate share with an output share Also, add a method `merge()` for merging two aggregate shares, as will be required for specifying aggregation in DAP. Co-authored-by: Brandon Pitman <[email protected]>
|
Rebased and squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #432.
Modify both
DafandVdafby replacingaggregate()with twomethods:
agg_init()returns an empty aggregate shareagg_update()updates an aggregate share with an output shareAlso, add a method
merge()for merging two aggregate shares, as will be required for specifying aggregation in DAP.