Pass of preliminaries #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
requested review from
bifurcation,
divergentdave and
schoppmp
as code owners
cjpatton
force-pushed
the
cjpatton/draft-13/5
branch
from
0cd2fe3 to
e0e7eab
Compare
Merged
divergentdave
approved these changes
Oct 12, 2024
draft-irtf-cfrg-vdaf.md
Outdated
Comment on lines
2083
to
2089
| `Field.gen()`. That is, `Field.gen()**Field.GEN_ORDER == Field(1)`, where | ||
| `**` denotes exponentiation in Python. |
There was a problem hiding this comment.
Technically, the definition of order also requires that Field.gen() ** (Field.GEN_ORDER // 2) != Field(1), but I don't know if we need to get into that level of detail.
There was a problem hiding this comment.
Changed to "This is the smallest positive integer for which ..."
cjpatton
force-pushed
the
cjpatton/draft-13/4
branch
3 times, most recently
from
1564f73 to
d82f274
Compare
cjpatton
force-pushed
the
cjpatton/draft-13/5
branch
from
e0e7eab to
af889bd
Compare
* Note that `Field.rand_vec()` is not used in the spec of any VDAF. (It's only used for `run_flp()`.) * Specify notation of arithmetic operations on fields. * Use `front()` in field element decoding, which is more in line with how we write down decoding algorithms in other parts of the draft. * Say what we mean by "order" of the multiplicative subgroup of NTT fields * XofTurboShake128: Set stricter bounds on the inputs (how big can the seed be) * XofFixedKeyAes128: Set bounds on the length of the domain separation tag. * Clarify the motivation for XofFixedKeyAes128. * Write "AES128" instead of "AES-128" as this is how we denote the function in the spec.
cjpatton
force-pushed
the
cjpatton/draft-13/5
branch
from
54b5bc8 to
e059f91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #483.
Note that
Field.rand_vec()is not used in the spec of any VDAF. (It's only used forrun_flp().)Specify notation of arithmetic operations on fields.
Use
front()in field element decoding, which is more in line with how we write down decoding algorithms in other parts of the draft.Say what we mean by "order" of the multiplicative subgroup of NTT fields
XofTurboShake128: Set stricter bounds on the inputs (how big can the seed be)
XofFixedKeyAes128: Set bounds on the length of the domain separation tag.
Clarify the motivation for XofFixedKeyAes128.
Write "AES128" instead of "AES-128" as this is how we denote the function in the spec.