This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Allow empty labels, move state CSS class to outer div. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd suggest bumping major version if you merge this, due to the CSS change. |
|
Ah, did you want me to remove the "Update build" commit from this PR? |
|
Yeah don't have the build commit. I do that on a release on github. That way the built js is what is stable. |
| if (!attrs.onLabel) { attrs.onLabel = toggleSwitchConfig.onLabel; } | ||
| if (!attrs.offLabel) { attrs.offLabel = toggleSwitchConfig.offLabel; } | ||
| if (!attrs.knobLabel) { attrs.knobLabel = toggleSwitchConfig.knobLabel; } | ||
| if (angular.isUndefined(attrs.onLabel)) { attrs.onLabel = toggleSwitchConfig.onLabel; } |
There was a problem hiding this comment.
Is there a specific reason you switched these? If I remember correctly, there is a reason we do this.
There was a problem hiding this comment.
Yes; because it was impossible to specify an empty label via a directive attribute.
foo = '';
!foo; // true
angular.isUndefined(foo); // false
You can try the new tests for empty labels on master and watch 'em fail.
|
(Will re-push without the 'Update build' commit tomorrow) |
|
Re-pushed without the Update build commit. |
|
Is this merge worthy? Anything I can do to clean it up? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cgarvis how do these changes look?