Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2etest/PROD-Thomas #1038

Merged
merged 5 commits into from
Nov 11, 2024
Merged

e2etest/PROD-Thomas #1038

merged 5 commits into from
Nov 11, 2024

Conversation

ThomasBedard
Copy link
Collaborator

Context:

Made an e2e test for edit a product name

Does this PR change the .vscode folder in petclinic-frontend?:

If the PR changes the .vscode folder, explain why in detail because it should not.
it doesn't

@ThomasBedard ThomasBedard changed the title added e2e test e2etest/PROD-Thomas Nov 11, 2024
Copy link
Collaborator

@Valthefirst Valthefirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your test works fine the only wickup is that is can't be run twice without re composing up

Copy link
Collaborator

@ZacharyLelievre ZacharyLelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well implemented! Good Job!

@ThomasBedard ThomasBedard merged commit 30c076d into main Nov 11, 2024
18 checks passed
@ThomasBedard ThomasBedard deleted the e2etest/PROD-Thomas branch November 11, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants