Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2etest/PROD-Zachary #1056

Merged
merged 2 commits into from
Nov 12, 2024
Merged

e2etest/PROD-Zachary #1056

merged 2 commits into from
Nov 12, 2024

Conversation

ZacharyLelievre
Copy link
Collaborator

JIRA: [Link to JIRA ticket]

Context:

This ticket focuses on adding a test to ensure that the review filter works correctly when users set a minimum rating equal to or higher than the maximum rating. The test verifies that an error message is displayed if this condition is met.

Does this PR change the .vscode folder in petclinic-frontend?:

No changes were made to the .vscode folder. Reviewers, please confirm that no unintentional changes were made to this folder.

Reviewers need to check for any changes to the
.vscode folder and add a comment about it to their review comments.

Changes

  • Added validation to the review filter for minimum and maximum star ratings.

Copy link
Collaborator

@Valthefirst Valthefirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jared hasn't left his mark here and the test works. All good!

@ZacharyLelievre ZacharyLelievre changed the title implemented the test filter by reviews e2etest/PROD-Zachary Nov 12, 2024
Copy link
Collaborator

@J91-cloud J91-cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your test does not have an expect, which means it really isnt doing anything

@cgerard321 cgerard321 merged commit 81fbcf0 into main Nov 12, 2024
18 checks passed
@cgerard321 cgerard321 deleted the e2etest/PROD-ZacharyLelievre branch November 12, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants