Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/CSTM-CPC-973-Display-All-Pet-Types #528

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

Saimirz
Copy link
Collaborator

@Saimirz Saimirz commented Oct 6, 2023

Displayed All Pet Types

JIRA: https://champlainsaintlambert.atlassian.net/browse/CPC-973?atlOrigin=eyJpIjoiNmViNzMzZTU3YWI1NGE1N2I2NTZmYjNiYTI0ZmE5OTAiLCJwIjoiaiJ9

Context:

User will be able to see what kind of pets we operate on.

Changes

I created the front end. A new page was made to display all petTypes. A new title was added in the owner dropdown to access the page.

Before and After UI (Required for UI-impacting PRs)

Before
image
After
image

image

Dev notes (Optional)

  • Specific technical changes that should be noted

Linked pull requests (Optional)

  • pull request link

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Qodana for JVM

334 new problems were found

Inspection name Severity Problems
Redundant character escape 🔶 Warning 85
Unused import 🔶 Warning 74
Dangling Javadoc comment 🔶 Warning 16
Invalid YAML configuration 🔶 Warning 11
Integer multiplication or shift implicitly cast to 'long' 🔶 Warning 7
Deprecated API usage 🔶 Warning 6
Link specified as plain text 🔶 Warning 6
Default annotation parameter value 🔶 Warning 5
Lombok annotations 🔶 Warning 5
Optional.get() is called without isPresent() check 🔶 Warning 5
AutoCloseable used without 'try'-with-resources 🔶 Warning 4
@NotNull/@Nullable problems 🔶 Warning 4
Redundant local variable 🔶 Warning 4
Unused assignment 🔶 Warning 4
Possibly blocking call in non-blocking context 🔶 Warning 3
Nullability and data flow problems 🔶 Warning 3
Field can be local 🔶 Warning 3
Spring Data repository method parameters errors 🔶 Warning 3
'Optional' used as field or parameter type 🔶 Warning 2
Unused publisher 🔶 Warning 2
Redundant type cast 🔶 Warning 2
Field may be 'final' 🔶 Warning 1
Lombok @Getter may be used 🔶 Warning 1
Mismatch in @PathVariable declarations and usages 🔶 Warning 1
@Value modifiers 🔶 Warning 1
Begin or end anchor in unexpected position 🔶 Warning 1
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 1
Call to 'printStackTrace()' 🔶 Warning 1
Unnecessary call to 'toString()' 🔶 Warning 1
Commented out code ◽️ Notice 36
Non recommended 'field' injections ◽️ Notice 18
Duplicated code fragment ◽️ Notice 13
Constant values ◽️ Notice 2
Mismatch in @PathVariable declarations and usages ◽️ Notice 1
Throw statement in Reactive operator ◽️ Notice 1
Regular expression can be simplified ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Qodana for JVM

327 new problems were found

Inspection name Severity Problems
Redundant character escape 🔶 Warning 85
Unused import 🔶 Warning 68
Dangling Javadoc comment 🔶 Warning 16
Invalid YAML configuration 🔶 Warning 11
Integer multiplication or shift implicitly cast to 'long' 🔶 Warning 9
Default annotation parameter value 🔶 Warning 5
Lombok annotations 🔶 Warning 5
Optional.get() is called without isPresent() check 🔶 Warning 5
AutoCloseable used without 'try'-with-resources 🔶 Warning 4
Deprecated API usage 🔶 Warning 4
Link specified as plain text 🔶 Warning 4
@NotNull/@Nullable problems 🔶 Warning 4
Redundant local variable 🔶 Warning 4
Unused assignment 🔶 Warning 4
Possibly blocking call in non-blocking context 🔶 Warning 3
Nullability and data flow problems 🔶 Warning 3
Field can be local 🔶 Warning 3
Spring Data repository method parameters errors 🔶 Warning 3
'Optional' used as field or parameter type 🔶 Warning 2
Unused publisher 🔶 Warning 2
Redundant type cast 🔶 Warning 2
Field may be 'final' 🔶 Warning 1
Lombok @Getter may be used 🔶 Warning 1
Mismatch in @PathVariable declarations and usages 🔶 Warning 1
Begin or end anchor in unexpected position 🔶 Warning 1
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 1
Call to 'printStackTrace()' 🔶 Warning 1
Unnecessary call to 'toString()' 🔶 Warning 1
Commented out code ◽️ Notice 37
Non recommended 'field' injections ◽️ Notice 18
Duplicated code fragment ◽️ Notice 13
Constant values ◽️ Notice 3
Mismatch in @PathVariable declarations and usages ◽️ Notice 1
Throw statement in Reactive operator ◽️ Notice 1
Regular expression can be simplified ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Collaborator

@Nmazza1 Nmazza1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, we should probably add functionality to Add, update and delete other pet types!

Copy link
Collaborator

@DisgruntledMensch DisgruntledMensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job man, adding a new page isn't easy

@Saimirz Saimirz merged commit def27fa into main Oct 9, 2023
3 checks passed
@Saimirz Saimirz deleted the feat/CSTM-CPC-973-Display-All-Pet-Types branch October 9, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants