feat(INVT-CPC-979): Add sale price for clients in product list

[DiSavio]

JIRA: link to jira ticket
https://champlainsaintlambert.atlassian.net/browse/CPC-979

What is the ticket about and why are we making this change?

This ticket is about adding an important field to our product list called the sale price. The sale price is important because previously we only had the normal price for a product that the pet clinic bought it for and we were missing the price we will be selling it at. We are making those changes because it's crucial information about a product.

What are the various changes and what other modules do those changes affect?

• The front end has been changed to accommodate the new field in the product list.
• A couple of things about the backend have been changed:

1. RequestDTO
2. ResponseDTO
3. Product Entity
4. ServiceImpl methods

• All the Testing that was using the DTOs, the Product entity and the serviceImpl has been changed to accommodate the new changes.
• API Gateway testing fully accommodated with the new changes.

Before and After UI (Required for UI-impacting PRs)

Before:

After:

[Matthewtan9]

Code looks good overall. Good job.

[Iantomasi]

Looks good, simple object value addition and logic has been updated acoordingly. UI shows the value.

[github-actions]

Qodana for JVM

336 new problems were found

Inspection name	Severity	Problems
Redundant character escape	🔶 Warning	85
Unused import	🔶 Warning	73
Dangling Javadoc comment	🔶 Warning	16
Invalid YAML configuration	🔶 Warning	11
Integer multiplication or shift implicitly cast to 'long'	🔶 Warning	9
Deprecated API usage	🔶 Warning	6
Link specified as plain text	🔶 Warning	6
Default annotation parameter value	🔶 Warning	5
Lombok annotations	🔶 Warning	5
Optional.get() is called without isPresent() check	🔶 Warning	5
AutoCloseable used without 'try'-with-resources	🔶 Warning	4
@NotNull/@Nullable problems	🔶 Warning	4
Redundant local variable	🔶 Warning	4
Unused assignment	🔶 Warning	4
Possibly blocking call in non-blocking context	🔶 Warning	3
Nullability and data flow problems	🔶 Warning	3
Field can be local	🔶 Warning	3
Spring Data repository method parameters errors	🔶 Warning	3
'Optional' used as field or parameter type	🔶 Warning	2
Unused publisher	🔶 Warning	2
Redundant type cast	🔶 Warning	2
Field may be 'final'	🔶 Warning	1
Lombok @Getter may be used	🔶 Warning	1
Mismatch in @PathVariable declarations and usages	🔶 Warning	1
@Value modifiers	🔶 Warning	1
Begin or end anchor in unexpected position	🔶 Warning	1
'size() == 0' can be replaced with 'isEmpty()'	🔶 Warning	1
Call to 'printStackTrace()'	🔶 Warning	1
Unnecessary call to 'toString()'	🔶 Warning	1
Commented out code	◽️ Notice	36
Non recommended 'field' injections	◽️ Notice	18
Duplicated code fragment	◽️ Notice	13
Constant values	◽️ Notice	3
Mismatch in @PathVariable declarations and usages	◽️ Notice	1
Throw statement in Reactive operator	◽️ Notice	1
Regular expression can be simplified	◽️ Notice	1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[github-actions]

Qodana for JVM

327 new problems were found

Inspection name	Severity	Problems
Redundant character escape	🔶 Warning	85
Unused import	🔶 Warning	68
Dangling Javadoc comment	🔶 Warning	16
Invalid YAML configuration	🔶 Warning	11
Integer multiplication or shift implicitly cast to 'long'	🔶 Warning	9
Default annotation parameter value	🔶 Warning	5
Lombok annotations	🔶 Warning	5
Optional.get() is called without isPresent() check	🔶 Warning	5
AutoCloseable used without 'try'-with-resources	🔶 Warning	4
Deprecated API usage	🔶 Warning	4
Link specified as plain text	🔶 Warning	4
@NotNull/@Nullable problems	🔶 Warning	4
Redundant local variable	🔶 Warning	4
Unused assignment	🔶 Warning	4
Possibly blocking call in non-blocking context	🔶 Warning	3
Nullability and data flow problems	🔶 Warning	3
Field can be local	🔶 Warning	3
Spring Data repository method parameters errors	🔶 Warning	3
'Optional' used as field or parameter type	🔶 Warning	2
Unused publisher	🔶 Warning	2
Redundant type cast	🔶 Warning	2
Field may be 'final'	🔶 Warning	1
Lombok @Getter may be used	🔶 Warning	1
Mismatch in @PathVariable declarations and usages	🔶 Warning	1
Begin or end anchor in unexpected position	🔶 Warning	1
'size() == 0' can be replaced with 'isEmpty()'	🔶 Warning	1
Call to 'printStackTrace()'	🔶 Warning	1
Unnecessary call to 'toString()'	🔶 Warning	1
Commented out code	◽️ Notice	37
Non recommended 'field' injections	◽️ Notice	18
Duplicated code fragment	◽️ Notice	13
Constant values	◽️ Notice	3
Mismatch in @PathVariable declarations and usages	◽️ Notice	1
Throw statement in Reactive operator	◽️ Notice	1
Regular expression can be simplified	◽️ Notice	1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions