Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(CSTM-CPC-879): fix pet edit to edit all values #538

Merged
merged 11 commits into from
Oct 10, 2023

Conversation

1-emil
Copy link
Collaborator

@1-emil 1-emil commented Oct 10, 2023

JIRA: link to jira ticket

Context:

Making It so the customer can edit the Name, Birthdate, and Pet Type. Previously you could only change the name.

Changes

  • Fixed Bug where the pet info in the form would dissapear
  • Added birthdate and pet type to owner details
  • Made birthdate and pet type editable

Before and After UI (Required for UI-impacting PRs)

image 2

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Qodana for JVM

345 new problems were found

Inspection name Severity Problems
Redundant character escape 🔶 Warning 85
Unused import 🔶 Warning 82
Dangling Javadoc comment 🔶 Warning 16
Invalid YAML configuration 🔶 Warning 11
Integer multiplication or shift implicitly cast to 'long' 🔶 Warning 9
Default annotation parameter value 🔶 Warning 5
Lombok annotations 🔶 Warning 5
Optional.get() is called without isPresent() check 🔶 Warning 5
AutoCloseable used without 'try'-with-resources 🔶 Warning 4
Deprecated API usage 🔶 Warning 4
Field can be local 🔶 Warning 4
Link specified as plain text 🔶 Warning 4
@NotNull/@Nullable problems 🔶 Warning 4
Redundant local variable 🔶 Warning 4
Unused assignment 🔶 Warning 4
Possibly blocking call in non-blocking context 🔶 Warning 3
Nullability and data flow problems 🔶 Warning 3
Spring Data repository method parameters errors 🔶 Warning 3
'Optional' used as field or parameter type 🔶 Warning 2
Unused publisher 🔶 Warning 2
Redundant type cast 🔶 Warning 2
Call to 'printStackTrace()' 🔶 Warning 2
Field may be 'final' 🔶 Warning 1
Lombok @Getter may be used 🔶 Warning 1
Mismatch in @PathVariable declarations and usages 🔶 Warning 1
Redundant 'close()' 🔶 Warning 1
Begin or end anchor in unexpected position 🔶 Warning 1
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 1
Unnecessary call to 'toString()' 🔶 Warning 1
Commented out code ◽️ Notice 37
Non recommended 'field' injections ◽️ Notice 18
Duplicated code fragment ◽️ Notice 14
Constant values ◽️ Notice 3
Mismatch in @PathVariable declarations and usages ◽️ Notice 1
Throw statement in Reactive operator ◽️ Notice 1
Regular expression can be simplified ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Collaborator

@DisgruntledMensch DisgruntledMensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, tests all passed.

Copy link
Collaborator

@mattjulienn mattjulienn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you got this bug out of the way 🙏Great job, Emil !

@1-emil 1-emil merged commit 2885fa5 into main Oct 10, 2023
3 checks passed
@1-emil 1-emil deleted the bug(CSTM-CPC-879)-Fix-pet-edit-to-edit-all-values branch October 10, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants