Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (INVT-CPC 991):Ability to make the products row hoverable #567

Conversation

Abdur-Siddiqui
Copy link
Collaborator

@Abdur-Siddiqui Abdur-Siddiqui commented Oct 21, 2023

JIRA: link to jira ticket
https://champlainsaintlambert.atlassian.net/browse/CPC-991

Context:

  • I added a hover element to the inventory products row
  • when u hover over the row you can see clearly which row you selected with the hover elements

Changes

  • I removed the product details folder because it's a unused directory the code is never being used.

I added a hover element to the inventory products row

  • My changes affect products

Before
image
After
image

@Abdur-Siddiqui Abdur-Siddiqui force-pushed the feat-INVT-CPC-991_Ability_to_make_the_products_row_hoverable branch from c2c9fdb to 030305d Compare October 21, 2023 22:45
@github-actions
Copy link

github-actions bot commented Oct 21, 2023

Qodana for JVM

353 new problems were found

Inspection name Severity Problems
Unused import 🔶 Warning 88
Redundant character escape 🔶 Warning 85
Dangling Javadoc comment 🔶 Warning 15
Invalid YAML configuration 🔶 Warning 11
Integer multiplication or shift implicitly cast to 'long' 🔶 Warning 10
Redundant local variable 🔶 Warning 6
Default annotation parameter value 🔶 Warning 5
Lombok annotations 🔶 Warning 5
Optional.get() is called without isPresent() check 🔶 Warning 5
AutoCloseable used without 'try'-with-resources 🔶 Warning 4
Deprecated API usage 🔶 Warning 4
Field can be local 🔶 Warning 4
Link specified as plain text 🔶 Warning 4
@NotNull/@Nullable problems 🔶 Warning 4
Spring Data repository method parameters errors 🔶 Warning 4
Unused assignment 🔶 Warning 4
Possibly blocking call in non-blocking context 🔶 Warning 3
Nullability and data flow problems 🔶 Warning 3
'Optional' used as field or parameter type 🔶 Warning 2
Unused publisher 🔶 Warning 2
Redundant type cast 🔶 Warning 2
Call to 'printStackTrace()' 🔶 Warning 2
Field may be 'final' 🔶 Warning 1
Lombok @Getter may be used 🔶 Warning 1
Mismatch in @PathVariable declarations and usages 🔶 Warning 1
Redundant 'close()' 🔶 Warning 1
Begin or end anchor in unexpected position 🔶 Warning 1
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 1
Unnecessary call to 'toString()' 🔶 Warning 1
Commented out code ◽️ Notice 35
Non recommended 'field' injections ◽️ Notice 18
Duplicated code fragment ◽️ Notice 16
Constant values ◽️ Notice 2
Mismatch in @PathVariable declarations and usages ◽️ Notice 1
Throw statement in Reactive operator ◽️ Notice 1
Regular expression can be simplified ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Collaborator

@Matthewtan9 Matthewtan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

Copy link
Collaborator

@Nmazza1 Nmazza1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend specifying in your PR why you deleted the file as it jarring opening the review to find a lot of deleted lines.

@Abdur-Siddiqui Abdur-Siddiqui merged commit b6adfd7 into main Oct 21, 2023
3 checks passed
@Abdur-Siddiqui Abdur-Siddiqui deleted the feat-INVT-CPC-991_Ability_to_make_the_products_row_hoverable branch October 21, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants