Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CSTM-CPC-876)Finalize Owner Details Page #570

Merged
merged 3 commits into from
Oct 22, 2023

Conversation

Nmazza1
Copy link
Collaborator

@Nmazza1 Nmazza1 commented Oct 22, 2023

JIRA: https://champlainsaintlambert.atlassian.net/browse/CPC-867?atlOrigin=eyJpIjoiYmJhODI4MjQ4YWE3NDM3Y2JlMjZkZjdmNTQzNzFjZDIiLCJwIjoiaiJ9

Context:

Owner Details did not match our end result goal

Changes

Changed page styling to match end goal and ensure responsiveness

Before and After UI (Required for UI-impacting PRs)

BEFORE
image
AFTER
image

Dev notes (Optional)

-Do people read these notes?

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

Qodana for JVM

354 new problems were found

Inspection name Severity Problems
Unused import 🔶 Warning 88
Redundant character escape 🔶 Warning 85
Dangling Javadoc comment 🔶 Warning 15
Invalid YAML configuration 🔶 Warning 11
Integer multiplication or shift implicitly cast to 'long' 🔶 Warning 10
Redundant local variable 🔶 Warning 6
Default annotation parameter value 🔶 Warning 5
Lombok annotations 🔶 Warning 5
Optional.get() is called without isPresent() check 🔶 Warning 5
AutoCloseable used without 'try'-with-resources 🔶 Warning 4
Deprecated API usage 🔶 Warning 4
Field can be local 🔶 Warning 4
Link specified as plain text 🔶 Warning 4
@NotNull/@Nullable problems 🔶 Warning 4
Spring Data repository method parameters errors 🔶 Warning 4
Unused assignment 🔶 Warning 4
Possibly blocking call in non-blocking context 🔶 Warning 3
Nullability and data flow problems 🔶 Warning 3
'Optional' used as field or parameter type 🔶 Warning 2
Unused publisher 🔶 Warning 2
Redundant type cast 🔶 Warning 2
Call to 'printStackTrace()' 🔶 Warning 2
Field may be 'final' 🔶 Warning 1
Lombok @Getter may be used 🔶 Warning 1
Mismatch in @PathVariable declarations and usages 🔶 Warning 1
Redundant 'close()' 🔶 Warning 1
Begin or end anchor in unexpected position 🔶 Warning 1
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 1
Unnecessary call to 'toString()' 🔶 Warning 1
Commented out code ◽️ Notice 35
Non recommended 'field' injections ◽️ Notice 18
Duplicated code fragment ◽️ Notice 17
Constant values ◽️ Notice 2
Mismatch in @PathVariable declarations and usages ◽️ Notice 1
Throw statement in Reactive operator ◽️ Notice 1
Regular expression can be simplified ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Collaborator

@DisgruntledMensch DisgruntledMensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff man, looks like we're at the finish line now.

Copy link
Collaborator

@1-emil 1-emil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow the new owner details page looks really clean man good job. The code looks good too

@Nmazza1 Nmazza1 merged commit 90e1c01 into main Oct 22, 2023
3 checks passed
@Nmazza1 Nmazza1 deleted the feat(CSTM-CPC-867)-Edit-Owner-Details-Page branch October 22, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants