-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/cstm cpc 1013 add pet weight #571
Conversation
I made the frontend look nicer and fixed the birthdate all i am missing is pet type
pet weight to backend
Updated confirmation and added a text box to input weight and fixed a small bug where pet status disappeared after editing pet
add pet not done yet but thats not my story
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, make sure all the testing is still working since you've added a new var.
Qodana for JVM355 new problems were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you adding a lot of code back to Owner Details after it was moved?
I did not add this code I think it added when i merged main with my branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case I suggest deleting the code if possible to keep the files organized, otherwise all good 👍
JIRA: link to jira ticket
Context:
Adding pet weight to front-end and back-end so the customer can edit the see their pet's weight and edit it
Changes
Before and After UI (Required for UI-impacting PRs)
I don't have a before image but its basically the form and confirmation message without the weight.
Dev notes (Optional)