Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cstm cpc 1013 add pet weight #571

Merged
merged 16 commits into from
Oct 22, 2023
Merged

Conversation

1-emil
Copy link
Collaborator

@1-emil 1-emil commented Oct 22, 2023

JIRA: link to jira ticket

Context:

Adding pet weight to front-end and back-end so the customer can edit the see their pet's weight and edit it

Changes

  • Add weight string
  • Add weight to confirmation when submitting edit pet form
  • add weight input text box to edit and add pet form
  • add weight text box to pet details to see weight

Before and After UI (Required for UI-impacting PRs)

Screenshot 2023-10-22 at 1 51 44 AM

I don't have a before image but its basically the form and confirmation message without the weight.

Dev notes (Optional)

  • I also fixed a small bug where isActive would be blank in the pet details after editing a pet.

Copy link
Collaborator

@DisgruntledMensch DisgruntledMensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, make sure all the testing is still working since you've added a new var.

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

Qodana for JVM

355 new problems were found

Inspection name Severity Problems
Unused import 🔶 Warning 88
Redundant character escape 🔶 Warning 85
Dangling Javadoc comment 🔶 Warning 15
Invalid YAML configuration 🔶 Warning 11
Integer multiplication or shift implicitly cast to 'long' 🔶 Warning 10
Redundant local variable 🔶 Warning 6
Default annotation parameter value 🔶 Warning 5
Lombok annotations 🔶 Warning 5
Optional.get() is called without isPresent() check 🔶 Warning 5
AutoCloseable used without 'try'-with-resources 🔶 Warning 4
Deprecated API usage 🔶 Warning 4
Field can be local 🔶 Warning 4
Link specified as plain text 🔶 Warning 4
@NotNull/@Nullable problems 🔶 Warning 4
Spring Data repository method parameters errors 🔶 Warning 4
Unused assignment 🔶 Warning 4
Possibly blocking call in non-blocking context 🔶 Warning 3
Nullability and data flow problems 🔶 Warning 3
'Optional' used as field or parameter type 🔶 Warning 2
Unused publisher 🔶 Warning 2
Redundant type cast 🔶 Warning 2
Call to 'printStackTrace()' 🔶 Warning 2
Field may be 'final' 🔶 Warning 1
Lombok @Getter may be used 🔶 Warning 1
Mismatch in @PathVariable declarations and usages 🔶 Warning 1
Redundant 'close()' 🔶 Warning 1
Begin or end anchor in unexpected position 🔶 Warning 1
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 1
Unnecessary call to 'toString()' 🔶 Warning 1
Commented out code ◽️ Notice 35
Duplicated code fragment ◽️ Notice 18
Non recommended 'field' injections ◽️ Notice 18
Constant values ◽️ Notice 2
Mismatch in @PathVariable declarations and usages ◽️ Notice 1
Throw statement in Reactive operator ◽️ Notice 1
Regular expression can be simplified ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Collaborator

@Nmazza1 Nmazza1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you adding a lot of code back to Owner Details after it was moved?

@1-emil
Copy link
Collaborator Author

1-emil commented Oct 22, 2023

Why are you adding a lot of code back to Owner Details after it was moved?

I did not add this code I think it added when i merged main with my branch

Copy link
Collaborator

@Nmazza1 Nmazza1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case I suggest deleting the code if possible to keep the files organized, otherwise all good 👍

@1-emil 1-emil merged commit e3077a2 into main Oct 22, 2023
3 checks passed
@1-emil 1-emil deleted the feat/CSTM-CPC-1013-Add-pet-weight branch October 22, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants