feat(AUTH-CPC-755): Add More Roles Front End #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JVM373 new problems were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
DylanBrass
reviewed
Oct 23, 2023
| @@ -12,7 +12,7 @@ const petClinicApp = angular.module('petClinicApp', [ | |||
| 'ui.router', 'layoutNav', 'layoutFooter', 'layoutWelcome', 'ownerList', 'ownerDetails', 'ownerForm', 'ownerRegister', 'petRegister', 'petForm' | |||
| , 'visits', 'vetList','vetForm','vetDetails', 'visitList', 'billForm', 'billUpdateForm', 'loginForm', 'rolesDetails', 'signupForm', 'productDetailsInfo', | |||
| 'billDetails', 'billsByOwnerId', 'billHistory','billsByVetId','inventoryList', 'inventoryForm', 'productForm','inventoryProductList', 'inventoryUpdateForm', 'productUpdateForm', | |||
| 'verification' , 'adminPanel','resetPwdForm','forgotPwdForm','petTypeList', 'petDetails','userDetails']); | |||
| 'verification' , 'adminPanel','resetPwdForm','forgotPwdForm','petTypeList', 'userModule', 'petDetails','userDetails']); | |||
There was a problem hiding this comment.
what is user module ? This PR is about roles.
| <td> | ||
| <!-- Using a nested ng-repeat to loop over each role in the user.roles array --> | ||
| <span ng-repeat="role in user.roles"> | ||
| {{ role.name }}<span ng-if="!$last">, </span> |
There was a problem hiding this comment.
What is this doing ? Is it reading from the fetched user ?
| templateUrl: 'scripts/auth/update-role-form/role-update.template.html', | ||
| controller: 'UpdateUserRoleController', | ||
| bindings: { | ||
| userId: '<' |
|
|
||
| angular.module('userModule').service('UserService', [function() { | ||
| this.getAvailableRoles = function() { | ||
| return ['ADMIN', 'VET', 'OWNER']; |
There was a problem hiding this comment.
Why are these values not fetched from the database, what happens if a new role is added ? For example I added the inventory manager ?
Comment on lines
+6
to
+9
| <input type="checkbox" class="form-check-input" id="{{role}}" ng-model="selectedRoles[role]" ng-true-value="'{{role}}'" ng-false-value="undefined"> | ||
| <label class="form-check-label" for="{{role}}">{{role}}</label> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Why are we using checkboxes ? Radio buttons would fit better since we would want to choose only one role.
Comment on lines
+30
to
+33
| if (rolesList.length > 1) { | ||
| alert('Please select only one role.'); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Why not use radio buttons instead of this bloated logic ?
SamuelNguyen2121
force-pushed
the
feat/AUTH-CPC-755-Add_More_Roles_Front_End
branch
from
5758a2f to
a82df7e
Compare
SamuelNguyen2121
force-pushed
the
feat/AUTH-CPC-755-Add_More_Roles_Front_End
branch
from
a82df7e to
889f5cc
Compare
Comment on lines
+1
to
+5
| 'use strict'; | ||
|
|
||
| angular.module('userModule').service('UserService', [function() { | ||
| this.getAvailableRoles = function() { | ||
| return ['ADMIN', 'VET', 'OWNER']; |
There was a problem hiding this comment.
Does this normally work with the default preexisting roles? New ones would prove to be an issue no?
AmirHamzahMirza
approved these changes
Oct 23, 2023
PaulJ2001
reviewed
Oct 23, 2023
There was a problem hiding this comment.
Dylan recently added his inventory manger story so I would recommend adding Inventory Manager as a role if you have the time.
PaulJ2001
approved these changes
Oct 23, 2023
SamuelNguyen2121
deleted the
feat/AUTH-CPC-755-Add_More_Roles_Front_End
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: link to jira ticket
https://champlainsaintlambert.atlassian.net/browse/CPC-755
Context:
What is the ticket about and why are we doing this change.
This ticket is about adding three roles, and one of them to be assigned to users because we want them to have a restricted access in the system. It is also about the feature for the admin to update the users' role if ever a user needs a different permission on the website.
Changes
What are the various changes and what other modules do those changes effect.
This can be bullet point or sentence format.
Before and After UI (Required for UI-impacting PRs)
If this is a change to the UI, include before and after screenshots to show the differences.
If this is a new UI feature, include screenshots to show reviewers what it looks like.
New "Update Role" Button and New "Role" Column in Admin Panel
New Update User Role Form (After Clicking Update Role Button)
Dev notes (Optional)
Linked pull requests (Optional)