Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(INVT-CPC-986): Ability to clear all search input fields #575

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

Eli293
Copy link
Collaborator

@Eli293 Eli293 commented Oct 22, 2023

JIRA: link to jira ticket
https://champlainsaintlambert.atlassian.net/browse/CPC-986

Context:

This ticket is about the ability to clear all input fields

Changes

  • Added Clear queries action handler
  • This affects both inventory and the product list
  • Will simply clear the input fields, then reset the list automatically
  • Added related icon

Before and After UI (Required for UI-impacting PRs)

Inventory-Before
image
Inventory-After
image
Product list-Before
image
Product list-After
image

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

Qodana for JVM

354 new problems were found

Inspection name Severity Problems
Unused import 🔶 Warning 88
Redundant character escape 🔶 Warning 85
Dangling Javadoc comment 🔶 Warning 15
Invalid YAML configuration 🔶 Warning 11
Integer multiplication or shift implicitly cast to 'long' 🔶 Warning 10
Redundant local variable 🔶 Warning 6
Default annotation parameter value 🔶 Warning 5
Lombok annotations 🔶 Warning 5
Optional.get() is called without isPresent() check 🔶 Warning 5
AutoCloseable used without 'try'-with-resources 🔶 Warning 4
Deprecated API usage 🔶 Warning 4
Field can be local 🔶 Warning 4
Link specified as plain text 🔶 Warning 4
@NotNull/@Nullable problems 🔶 Warning 4
Spring Data repository method parameters errors 🔶 Warning 4
Unused assignment 🔶 Warning 4
Possibly blocking call in non-blocking context 🔶 Warning 3
Nullability and data flow problems 🔶 Warning 3
'Optional' used as field or parameter type 🔶 Warning 2
Unused publisher 🔶 Warning 2
Redundant type cast 🔶 Warning 2
Call to 'printStackTrace()' 🔶 Warning 2
Field may be 'final' 🔶 Warning 1
Lombok @Getter may be used 🔶 Warning 1
Mismatch in @PathVariable declarations and usages 🔶 Warning 1
Redundant 'close()' 🔶 Warning 1
Begin or end anchor in unexpected position 🔶 Warning 1
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 1
Unnecessary call to 'toString()' 🔶 Warning 1
Commented out code ◽️ Notice 35
Non recommended 'field' injections ◽️ Notice 18
Duplicated code fragment ◽️ Notice 17
Constant values ◽️ Notice 2
Mismatch in @PathVariable declarations and usages ◽️ Notice 1
Throw statement in Reactive operator ◽️ Notice 1
Regular expression can be simplified ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Abdur-Siddiqui
Abdur-Siddiqui previously approved these changes Oct 22, 2023
Copy link
Collaborator

@Abdur-Siddiqui Abdur-Siddiqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good job on adding the clear functionality

Matthewtan9
Matthewtan9 previously approved these changes Oct 22, 2023
Copy link
Collaborator

@Matthewtan9 Matthewtan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. A nice feature that I didn't even think about.

@Eli293 Eli293 dismissed stale reviews from Abdur-Siddiqui and Matthewtan9 via 5db284e October 22, 2023 20:42
@Eli293 Eli293 force-pushed the Feat/INVT-CPC-986_Ability_to_clear_all_search_queries branch from ac91b0e to 5db284e Compare October 22, 2023 20:42
@Eli293 Eli293 merged commit b7282e2 into main Oct 22, 2023
3 checks passed
@Eli293 Eli293 deleted the Feat/INVT-CPC-986_Ability_to_clear_all_search_queries branch October 22, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants