feat(BILL-CPC-934) Implement Negative Testing in BillServiceImplTest

[MinseokBUZZ]

JIRA: https://champlainsaintlambert.atlassian.net/jira/software/c/projects/CPC/boards/15/backlog?selectedIssue=CPC-934

Context:

This ticket involves adding negative tests to the BillServiceImplTest to ensure that the service behaves correctly when encountering various error scenarios.

Changes

Created 6 negative tests,

• test_getBillByNonExistentBillId
• test_updateNonExistentBillId
• test_deleteNonExistentBillId
• test_updateBillWithInvalidRequest
• test_GetBillByNonExistentCustomerId
• test_CreateBillWithInvalidData

Before and After UI (Required for UI-impacting PRs)

Dev notes (Optional)

Linked pull requests (Optional)

[github-actions]

Qodana for JVM

356 new problems were found

Inspection name	Severity	Problems
Unused import	🔶 Warning	90
Redundant character escape	🔶 Warning	85
Dangling Javadoc comment	🔶 Warning	15
Invalid YAML configuration	🔶 Warning	11
Integer multiplication or shift implicitly cast to 'long'	🔶 Warning	10
Redundant local variable	🔶 Warning	6
Default annotation parameter value	🔶 Warning	5
Lombok annotations	🔶 Warning	5
Optional.get() is called without isPresent() check	🔶 Warning	5
AutoCloseable used without 'try'-with-resources	🔶 Warning	4
Deprecated API usage	🔶 Warning	4
Field can be local	🔶 Warning	4
Link specified as plain text	🔶 Warning	4
@NotNull/@Nullable problems	🔶 Warning	4
Spring Data repository method parameters errors	🔶 Warning	4
Unused assignment	🔶 Warning	4
Possibly blocking call in non-blocking context	🔶 Warning	3
Nullability and data flow problems	🔶 Warning	3
'Optional' used as field or parameter type	🔶 Warning	2
Unused publisher	🔶 Warning	2
Redundant type cast	🔶 Warning	2
Call to 'printStackTrace()'	🔶 Warning	2
Field may be 'final'	🔶 Warning	1
Lombok @Getter may be used	🔶 Warning	1
Mismatch in @PathVariable declarations and usages	🔶 Warning	1
Redundant 'close()'	🔶 Warning	1
Begin or end anchor in unexpected position	🔶 Warning	1
'size() == 0' can be replaced with 'isEmpty()'	🔶 Warning	1
Unnecessary call to 'toString()'	🔶 Warning	1
Commented out code	◽️ Notice	34
Duplicated code fragment	◽️ Notice	18
Non recommended 'field' injections	◽️ Notice	18
Constant values	◽️ Notice	2
Mismatch in @PathVariable declarations and usages	◽️ Notice	1
Throw statement in Reactive operator	◽️ Notice	1
Regular expression can be simplified	◽️ Notice	1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[ebond07]

Good job on the negative tests.

[drallo22]

Good job!