Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT(INVT-CPC-994): fixed the styling of products details page bug #583

Conversation

Abdur-Siddiqui
Copy link
Collaborator

JIRA: link to jira ticket
https://champlainsaintlambert.atlassian.net/browse/CPC-994

Context:

  • I modified the styling to get product details

Changes

  • Added a card element to display the details in a card format
  • removed the box and the lines that was surrounding the text

Before and After UI (Required for UI-impacting PRs)

Before
image

After
image

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Qodana for JVM

352 new problems were found

Inspection name Severity Problems
Unused import 🔶 Warning 90
Redundant character escape 🔶 Warning 85
Dangling Javadoc comment 🔶 Warning 15
Invalid YAML configuration 🔶 Warning 11
Integer multiplication or shift implicitly cast to 'long' 🔶 Warning 10
Optional.get() is called without isPresent() check 🔶 Warning 6
Redundant local variable 🔶 Warning 6
Default annotation parameter value 🔶 Warning 5
AutoCloseable used without 'try'-with-resources 🔶 Warning 4
Deprecated API usage 🔶 Warning 4
Field can be local 🔶 Warning 4
Link specified as plain text 🔶 Warning 4
@NotNull/@Nullable problems 🔶 Warning 4
Spring Data repository method parameters errors 🔶 Warning 4
Unused assignment 🔶 Warning 4
Possibly blocking call in non-blocking context 🔶 Warning 3
Nullability and data flow problems 🔶 Warning 3
'Optional' used as field or parameter type 🔶 Warning 2
Unused publisher 🔶 Warning 2
Redundant type cast 🔶 Warning 2
Call to 'printStackTrace()' 🔶 Warning 2
Field may be 'final' 🔶 Warning 1
Lombok @Getter may be used 🔶 Warning 1
Mismatch in @PathVariable declarations and usages 🔶 Warning 1
Redundant 'close()' 🔶 Warning 1
Begin or end anchor in unexpected position 🔶 Warning 1
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 1
Unnecessary call to 'toString()' 🔶 Warning 1
Commented out code ◽️ Notice 34
Duplicated code fragment ◽️ Notice 18
Non recommended 'field' injections ◽️ Notice 18
Constant values ◽️ Notice 2
Mismatch in @PathVariable declarations and usages ◽️ Notice 1
Throw statement in Reactive operator ◽️ Notice 1
Regular expression can be simplified ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@Abdur-Siddiqui Abdur-Siddiqui force-pushed the feat-INVT-CPC-994-ability-to-fix-the-styling-of-the-product-details-form branch from 577bb5a to 49675cc Compare October 23, 2023 04:05
Copy link
Collaborator

@DiSavio DiSavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good good job Abdur

Copy link
Collaborator

@DylanBrass DylanBrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Abdur-Siddiqui Abdur-Siddiqui force-pushed the feat-INVT-CPC-994-ability-to-fix-the-styling-of-the-product-details-form branch from 9002749 to 17327d9 Compare October 23, 2023 04:20
@Abdur-Siddiqui Abdur-Siddiqui merged commit b8d05b4 into main Oct 23, 2023
3 checks passed
@Abdur-Siddiqui Abdur-Siddiqui deleted the feat-INVT-CPC-994-ability-to-fix-the-styling-of-the-product-details-form branch October 23, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants