Bug/cstm cpc 1014 fix pet date and update pet form

[1-emil]

JIRA: link to jira ticket

Context:

There's a bug with the date and edit pet form since the new pet details page has been added, this pr fixes the issues

Changes

Fixed pet birth date on owner details page and pet details page and also removed the duplicate pet type selector on edit pet form

Before and After UI (Required for UI-impacting PRs)

before

after

[github-actions]

Qodana for JVM

374 new problems were found

Inspection name	Severity	Problems
Unused import	🔶 Warning	103
Redundant character escape	🔶 Warning	85
Dangling Javadoc comment	🔶 Warning	15
Invalid YAML configuration	🔶 Warning	11
Integer multiplication or shift implicitly cast to 'long'	🔶 Warning	10
AutoCloseable used without 'try'-with-resources	🔶 Warning	6
Optional.get() is called without isPresent() check	🔶 Warning	6
Default annotation parameter value	🔶 Warning	5
Field can be local	🔶 Warning	5
Redundant local variable	🔶 Warning	5
Nullability and data flow problems	🔶 Warning	4
Deprecated API usage	🔶 Warning	4
Link specified as plain text	🔶 Warning	4
@NotNull/@Nullable problems	🔶 Warning	4
Spring Data repository method parameters errors	🔶 Warning	4
Unused assignment	🔶 Warning	4
Possibly blocking call in non-blocking context	🔶 Warning	3
Call to 'printStackTrace()'	🔶 Warning	3
'Optional' used as field or parameter type	🔶 Warning	2
Unused publisher	🔶 Warning	2
Redundant type cast	🔶 Warning	2
Redundant 'close()'	🔶 Warning	2
Calling 'subscribe' in "reactive" methods	🔶 Warning	1
Field may be 'final'	🔶 Warning	1
Lombok @Getter may be used	🔶 Warning	1
Mismatch in @PathVariable declarations and usages	🔶 Warning	1
Begin or end anchor in unexpected position	🔶 Warning	1
'size() == 0' can be replaced with 'isEmpty()'	🔶 Warning	1
Unnecessary call to 'toString()'	🔶 Warning	1
Commented out code	◽️ Notice	35
Duplicated code fragment	◽️ Notice	19
Non recommended 'field' injections	◽️ Notice	19
Constant values	◽️ Notice	2
Mismatch in @PathVariable declarations and usages	◽️ Notice	1
Throw statement in Reactive operator	◽️ Notice	1
Regular expression can be simplified	◽️ Notice	1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[Nmazza1]

Weird. I didn't see two pet type selectors on my machine. Could it be a OS or browser specific issue?

[1-emil]

Weird. I didn't see two pet type selectors on my machine. Could it be a OS or browser specific issue?

Yeah probably from my end or weird merging issues but hopefully this pr will fix it for me and for everyone else assuming they also had 2 selectors in edit pet form

[swafit]

Weird. I didn't see two pet type selectors on my machine. Could it be a OS or browser specific issue?

Yeah probably from my end or weird merging issues but hopefully this pr will fix it for me and for everyone else assuming they also had 2 selectors in edit pet form

What do you mean by hopefully this pr will fix it?

[Nmazza1]

Weird. I didn't see two pet type selectors on my machine. Could it be a OS or browser specific issue?

Yeah probably from my end or weird merging issues but hopefully this pr will fix it for me and for everyone else assuming they also had 2 selectors in edit pet form

What do you mean by hopefully this pr will fix it?

Assuming this bug happens in certain cases this PR will fix it.

[DisgruntledMensch]

All good lad