feat(VIST-CPC-811): send email on visit request #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JVM374 new problems were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
CptDoritos
reviewed
Oct 23, 2023
...gateway/src/main/java/com/petclinic/bffapigateway/domainclientlayer/VisitsServiceClient.java
Show resolved
Hide resolved
Comment on lines
+17
to
+29
| public Mono<? extends Throwable> rethrow(ClientResponse clientResponse, Function<Map, ? extends Throwable> exceptionProvider) { | ||
| return clientResponse.createException().flatMap(n -> | ||
| { | ||
| try { | ||
| final Map map = | ||
| objectMapper.readValue(n.getResponseBodyAsString(), Map.class); | ||
| return Mono.error(exceptionProvider.apply(map)); | ||
| } catch (JsonProcessingException e) { | ||
| // e.printStackTrace(); | ||
| return Mono.error(e); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
Can you clarify what this method is doing and why you need it?
There was a problem hiding this comment.
It rethrows error to what called it. I need it because of how the authServiceClient was implemented(copied from the api-gateway).
| @@ -80,11 +88,20 @@ public Mono<VisitResponseDTO> addVisit(Mono<VisitRequestDTO> visitRequestDTOMono | |||
| .then(validatePetId(visitRequestDTO.getPetId())) | |||
| .then(validateVetId(visitRequestDTO.getPractitionerId())) | |||
| .then(Mono.just(visitRequestDTO)) | |||
| .doOnNext(s->{ | |||
|
|
|||
| authServiceClient.getUserById(visitRequestDTO.getJwtToken(), visitRequestDTO.getOwnerId()).subscribe(user->mailService.sendMail(generateVisitRequestEmail(user, visitRequestDTO.getPetId(), visitRequestDTO.getVisitDate()))); | |||
There was a problem hiding this comment.
can you explain what .subscribe () is doing here?
There was a problem hiding this comment.
It allows to run code once we get the return from the asynchronous getUserById method from the AuthServiceClient. In this case, it is a non blocking way to wait to get the user, then go ahead with sending the email.
CptDoritos
approved these changes
Oct 23, 2023
MichaelVacca
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: link to jira ticket
Context:
Sending an email to the pet owner when a visit is requested/scheduled.
Changes
Added AuthServiceClient and mailerClient integration to be able to send emails.
Before and After UI (Required for UI-impacting PRs)
Image of an email sent when a visit is added.
Dev notes (Optional)