Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(CSTM-CPC-1017)Fixed Pet UUID Generation and Pet Type Display #592

Merged

Conversation

Nmazza1
Copy link
Collaborator

@Nmazza1 Nmazza1 commented Oct 23, 2023

JIRA: link to jira ticket

Context:

On pet generation the UUID came out wonky.

Changes

Fixed the UUID Generation
Fixed Pet Type not displaying properly

Dev notes (Optional)

I'm watching you ๐Ÿ‘๏ธ ๐Ÿ‘๏ธ

Copy link
Collaborator

@DisgruntledMensch DisgruntledMensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we're just about done then. Good job m8.

Copy link
Collaborator

@1-emil 1-emil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good there's not much to say about it since its a really small bug fix but good job!

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Qodana for JVM

374 new problems were found

Inspection name Severity Problems
Unused import ๐Ÿ”ถ Warning 103
Redundant character escape ๐Ÿ”ถ Warning 85
Dangling Javadoc comment ๐Ÿ”ถ Warning 15
Invalid YAML configuration ๐Ÿ”ถ Warning 11
Integer multiplication or shift implicitly cast to 'long' ๐Ÿ”ถ Warning 10
AutoCloseable used without 'try'-with-resources ๐Ÿ”ถ Warning 6
Optional.get() is called without isPresent() check ๐Ÿ”ถ Warning 6
Default annotation parameter value ๐Ÿ”ถ Warning 5
Field can be local ๐Ÿ”ถ Warning 5
Redundant local variable ๐Ÿ”ถ Warning 5
Nullability and data flow problems ๐Ÿ”ถ Warning 4
Deprecated API usage ๐Ÿ”ถ Warning 4
Link specified as plain text ๐Ÿ”ถ Warning 4
@NotNull/@Nullable problems ๐Ÿ”ถ Warning 4
Spring Data repository method parameters errors ๐Ÿ”ถ Warning 4
Unused assignment ๐Ÿ”ถ Warning 4
Possibly blocking call in non-blocking context ๐Ÿ”ถ Warning 3
Call to 'printStackTrace()' ๐Ÿ”ถ Warning 3
'Optional' used as field or parameter type ๐Ÿ”ถ Warning 2
Unused publisher ๐Ÿ”ถ Warning 2
Redundant type cast ๐Ÿ”ถ Warning 2
Redundant 'close()' ๐Ÿ”ถ Warning 2
Calling 'subscribe' in "reactive" methods ๐Ÿ”ถ Warning 1
Field may be 'final' ๐Ÿ”ถ Warning 1
Lombok @Getter may be used ๐Ÿ”ถ Warning 1
Mismatch in @PathVariable declarations and usages ๐Ÿ”ถ Warning 1
Begin or end anchor in unexpected position ๐Ÿ”ถ Warning 1
'size() == 0' can be replaced with 'isEmpty()' ๐Ÿ”ถ Warning 1
Unnecessary call to 'toString()' ๐Ÿ”ถ Warning 1
Commented out code โ—ฝ๏ธ Notice 35
Duplicated code fragment โ—ฝ๏ธ Notice 19
Non recommended 'field' injections โ—ฝ๏ธ Notice 19
Constant values โ—ฝ๏ธ Notice 2
Mismatch in @PathVariable declarations and usages โ—ฝ๏ธ Notice 1
Throw statement in Reactive operator โ—ฝ๏ธ Notice 1
Regular expression can be simplified โ—ฝ๏ธ Notice 1

โ˜๏ธ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@Nmazza1 Nmazza1 merged commit b50675d into main Oct 24, 2023
3 checks passed
@Nmazza1 Nmazza1 deleted the bug(CSTM-CPC-1017)Fix-Pet-UUID-Generation-and-Pet-Type-Appearance branch October 24, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants