feat/BILL-CPC-905_Implement_Pagination_System_For_BillHistory_Page

[dazhuox]

JIRA: https://champlainsaintlambert.atlassian.net/browse/CPC-905?atlOrigin=eyJpIjoiNmI1ODdhOWRiM2M4NDJkMTkwZjdhN2Q4NjgyMjg0NjMiLCJwIjoiaiJ9

Context:

This ticket implements the pagination system for the Bill History page (getAllBillsByPage).

Changes

• There are buttons now to help the user navigate from one set of list (page) of bills to another.
• The url of the page is changed to the new pagination method.
• The url accepts params that allow the selection of how many items users want to see per page.

Before and After UI (Required for UI-impacting PRs)

Before implementation:

After implementation:

Dev notes (Optional)

• Specific technical changes that should be noted

Linked pull requests (Optional)

• pull request link

[drallo22]

Very useful especially if we have a lot of bills, good job!

[drallo22]

Could have been done using switch or if-else statements but this works fine as well!

[dazhuox]

I didn't think about that, it could definitely work. My usual preference are if statements so I'll stick with that

[swafit]

Could have been done using switch or if-else statements but this works fine as well!

In this case an if-else is better since you might have more than one query param that is not provided.

[github-actions]

Qodana for JVM

419 new problems were found

Inspection name	Severity	Problems
Unused import	🔶 Warning	129
Redundant character escape	🔶 Warning	85
Dangling Javadoc comment	🔶 Warning	15
Integer multiplication or shift implicitly cast to 'long'	🔶 Warning	12
Invalid YAML configuration	🔶 Warning	9
Field can be local	🔶 Warning	7
AutoCloseable used without 'try'-with-resources	🔶 Warning	6
Redundant 'Collection.addAll()' call	🔶 Warning	6
Optional.get() is called without isPresent() check	🔶 Warning	6
Redundant local variable	🔶 Warning	6
Default annotation parameter value	🔶 Warning	5
Nullability and data flow problems	🔶 Warning	4
Deprecated API usage	🔶 Warning	4
Link specified as plain text	🔶 Warning	4
@NotNull/@Nullable problems	🔶 Warning	4
Spring Data repository method parameters errors	🔶 Warning	4
Unused assignment	🔶 Warning	4
Possibly blocking call in non-blocking context	🔶 Warning	3
Field may be 'final'	🔶 Warning	3
Lombok @Getter may be used	🔶 Warning	3
Call to 'printStackTrace()'	🔶 Warning	3
Non-final field in 'enum'	🔶 Warning	2
'Optional' used as field or parameter type	🔶 Warning	2
Unused publisher	🔶 Warning	2
Redundant type cast	🔶 Warning	2
Redundant 'close()'	🔶 Warning	2
Calling 'subscribe' in "reactive" methods	🔶 Warning	1
Mismatch in @PathVariable declarations and usages	🔶 Warning	1
Begin or end anchor in unexpected position	🔶 Warning	1
'size() == 0' can be replaced with 'isEmpty()'	🔶 Warning	1
Unchecked warning	🔶 Warning	1
Unnecessary call to 'toString()'	🔶 Warning	1
Commented out code	◽️ Notice	36
Duplicated code fragment	◽️ Notice	21
Non recommended 'field' injections	◽️ Notice	19
Constant values	◽️ Notice	2
Mismatch in @PathVariable declarations and usages	◽️ Notice	1
Throw statement in Reactive operator	◽️ Notice	1
Regular expression can be simplified	◽️ Notice	1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions