Feat/cart/cpc 1033/retrieve cart for client #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fications to the application.yaml to add a mongo database. still have to put it on the api gateway
… profiles("test")
now every test pass
|
Everything looks fine to me. |
NtsoaElie
approved these changes
Sep 15, 2024
NtsoaElie
approved these changes
Sep 15, 2024
NtsoaElie
approved these changes
Sep 15, 2024
nic5694
reviewed
Sep 15, 2024
Comment on lines
+47
to
+67
| // @Test | ||
| // void findCartByCartId_withExistingId_thenReturnCart() { | ||
| // StepVerifier | ||
| // .create(cartRepository.save(cart1)) | ||
| // .consumeNextWith(insertedCart -> { | ||
| // assertNotNull(insertedCart); | ||
| // assertEquals(cart1.getCartId(), insertedCart.getCartId()); | ||
| // assertEquals(cart1.getCustomerId(), insertedCart.getCustomerId()); | ||
| // }) | ||
| // .verifyComplete(); | ||
| // | ||
| // //act and assert | ||
| // StepVerifier | ||
| // .create(cartRepository.findCartByCartId(cart1.getCartId())) | ||
| // .consumeNextWith(foundCart -> { | ||
| // assertNotNull(foundCart); | ||
| // assertEquals(cart1.getCartId(), foundCart.getCartId()); | ||
| // assertEquals(cart1.getCustomerId(), foundCart.getCustomerId()); | ||
| // }) | ||
| // .verifyComplete(); | ||
| // } |
There was a problem hiding this comment.
You should not be pushing commented out code into main.
There was a problem hiding this comment.
Thank you. This will be fixed ASAP
Zako563
approved these changes
Sep 16, 2024
viktorkuts
pushed a commit
that referenced
this pull request
Sep 17, 2024
JIRA: https://champlainsaintlambert.atlassian.net/browse/CPC-1033 ## Context: Retrieve the informations of a cart with all its products using a clientId ## Changes - created the cart entity - implemented the get cart by cart id - added a domain client layer for a product client - added some tests - modified the application.yaml to integrate a mongo Database ## Dev notes (Optional) - Still need to add it to the API gateway --------- Co-authored-by: NtsoaElie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://champlainsaintlambert.atlassian.net/browse/CPC-1033
Context:
Retrieve the informations of a cart with all its products using a clientId
Changes
Dev notes (Optional)