Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/(VIST-CPC-1119): display visits #630

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

ioannisp03
Copy link
Collaborator

https://champlainsaintlambert.atlassian.net/browse/CPC-1119

Context:

View All The Visits using getAllVisits

Changes

Added a controller in the API Gateway under the V2 folder with a getAllVisits with a new V2 endpoint.
Added some ControllerUniTests to test getAllVisits.
Created a folder in react that hold the visit page.

Dev notes (Optional)

  • Still missing other tests, still need to display all the visits and add the route to the visit page

Copy link
Collaborator

@Zako563 Zako563 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It follows the same template as the other teams did for each class. So the code is good

Copy link
Collaborator

@Rrregine Rrregine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regine approves.

@ioannisp03 ioannisp03 merged commit 287584f into main Sep 15, 2024
14 checks passed
@ioannisp03 ioannisp03 deleted the feat/VIST-CPC-1119_Display_Visits branch September 15, 2024 18:41
@ioannisp03 ioannisp03 changed the title Feat/vist/cpc 1119/display visits feat/(VIST-CPC-1119): display visits Sep 16, 2024
viktorkuts pushed a commit that referenced this pull request Sep 17, 2024
https://champlainsaintlambert.atlassian.net/browse/CPC-1119
## Context:
View All The Visits using getAllVisits
## Changes
Added a controller in the API Gateway under the V2 folder with a
getAllVisits with a new V2 endpoint.
Added some ControllerUniTests to test getAllVisits.
Created a folder in react that hold the visit page.

## Dev notes (Optional)
- Still missing other tests, still need to display all the visits and
add the route to the visit page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants