feat/(CUST-CPC-1075): Being Able To Add Customer To Website #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have to fix the positive test
all is DONE
AndrewBadIdea
previously approved these changes
Sep 14, 2024
…mer_To_The_Website
NotZagreus
dismissed stale reviews from AndrewBadIdea and flyindonut
via
90e9d8a
NotZagreus
requested review from
AndrewBadIdea,
flyindonut and
AlejandroBrnab
flyindonut
approved these changes
Sep 15, 2024
AndrewBadIdea
approved these changes
Sep 15, 2024
NotZagreus
deleted the
feat/CUST-CPC-1075_Being_Able_To_Add_A_Customer_To_The_Website
branch
viktorkuts
pushed a commit
that referenced
this pull request
Sep 17, 2024
JIRA: https://champlainsaintlambert.atlassian.net/browse/CPC-1075 ## Context: Added a v2 endpoint for being able to add a customer (as an admin). Adding a web form to input customer details, following the "Customer Profile Edit" form created previously. ## Changes - Added the "addOwner" v2 method to the CustomersServiceClient impoving the already existing "createOwner" method, since that one was not operational. - Created the endpoint to add an owner in the OwnerController - Created the TypeScript Model for "Owner" - Created the api call method to the new endpoint (addOwner.ts) - Based on the "Customer Profile Edit" form, created "Add Customer" form to conform to the addition of a customer. - Adding the routing for adding the customer in "router.tsx" - Fixing a small navigation issue in "Profile Edit" - Adding the path routes for the form created - Tested the "addOwner" method ## Before and After UI (Required for UI-impacting PRs) 
flyindonut
added a commit
that referenced
this pull request
Sep 18, 2024
**JIRA:** https://champlainsaintlambert.atlassian.net/browse/CPC-1134 ## Context: Currently, users can access every page that the axiosErrorResponseHandler doesn't handle. This means that an admin or vet is able to access the customer profile edit page which only a customer should be able to see. ## Does this PR change the .vscode folder in petclinic-frontend?: Absolutely not. I hope. ## Changes - Created a hook to validate user roles (useHasRequiredRole.ts). Implemented it in the ProtectedRouteProps.tsx - Added the roles that are authorized to access ProfileEdit, AddingCustomer, and AllOwners. Other teams can implement it to their pages as well (see dev notes). - Created 4 additional functions that people can use in the UserContext.tsx - Refactored and reorganized the ProfileEdit.tsx. The update form is now a component in the newly created components folder in features/customers ## Before and After UI (Required for UI-impacting PRs) No change to the UI. Users will just be redirected to 403 Forbidden when they access pages they shouldn't see ## Dev notes (Optional) If you want to make a page accessible by roles, just take a look at router.tsx. Pages that trigger the axiosErrorResponseHandler will automatically redirect users to an error page. If you want to be consistent, then add roles to each page that would require it. ## Linked pull requests (Optional) Update Customer #622 Add Customer #632 Show all customers #634
hristoiv11
pushed a commit
that referenced
this pull request
Sep 20, 2024
**JIRA:** https://champlainsaintlambert.atlassian.net/browse/CPC-1134 Currently, users can access every page that the axiosErrorResponseHandler doesn't handle. This means that an admin or vet is able to access the customer profile edit page which only a customer should be able to see. Absolutely not. I hope. - Created a hook to validate user roles (useHasRequiredRole.ts). Implemented it in the ProtectedRouteProps.tsx - Added the roles that are authorized to access ProfileEdit, AddingCustomer, and AllOwners. Other teams can implement it to their pages as well (see dev notes). - Created 4 additional functions that people can use in the UserContext.tsx - Refactored and reorganized the ProfileEdit.tsx. The update form is now a component in the newly created components folder in features/customers No change to the UI. Users will just be redirected to 403 Forbidden when they access pages they shouldn't see If you want to make a page accessible by roles, just take a look at router.tsx. Pages that trigger the axiosErrorResponseHandler will automatically redirect users to an error page. If you want to be consistent, then add roles to each page that would require it. Update Customer #622 Add Customer #632 Show all customers #634
hristoiv11
pushed a commit
that referenced
this pull request
Sep 20, 2024
**JIRA:** https://champlainsaintlambert.atlassian.net/browse/CPC-1134 Currently, users can access every page that the axiosErrorResponseHandler doesn't handle. This means that an admin or vet is able to access the customer profile edit page which only a customer should be able to see. Absolutely not. I hope. - Created a hook to validate user roles (useHasRequiredRole.ts). Implemented it in the ProtectedRouteProps.tsx - Added the roles that are authorized to access ProfileEdit, AddingCustomer, and AllOwners. Other teams can implement it to their pages as well (see dev notes). - Created 4 additional functions that people can use in the UserContext.tsx - Refactored and reorganized the ProfileEdit.tsx. The update form is now a component in the newly created components folder in features/customers No change to the UI. Users will just be redirected to 403 Forbidden when they access pages they shouldn't see If you want to make a page accessible by roles, just take a look at router.tsx. Pages that trigger the axiosErrorResponseHandler will automatically redirect users to an error page. If you want to be consistent, then add roles to each page that would require it. Update Customer #622 Add Customer #632 Show all customers #634
hristoiv11
pushed a commit
that referenced
this pull request
Sep 20, 2024
**JIRA:** https://champlainsaintlambert.atlassian.net/browse/CPC-1134 Currently, users can access every page that the axiosErrorResponseHandler doesn't handle. This means that an admin or vet is able to access the customer profile edit page which only a customer should be able to see. Absolutely not. I hope. - Created a hook to validate user roles (useHasRequiredRole.ts). Implemented it in the ProtectedRouteProps.tsx - Added the roles that are authorized to access ProfileEdit, AddingCustomer, and AllOwners. Other teams can implement it to their pages as well (see dev notes). - Created 4 additional functions that people can use in the UserContext.tsx - Refactored and reorganized the ProfileEdit.tsx. The update form is now a component in the newly created components folder in features/customers No change to the UI. Users will just be redirected to 403 Forbidden when they access pages they shouldn't see If you want to make a page accessible by roles, just take a look at router.tsx. Pages that trigger the axiosErrorResponseHandler will automatically redirect users to an error page. If you want to be consistent, then add roles to each page that would require it. Update Customer #622 Add Customer #632 Show all customers #634
hristoiv11
pushed a commit
that referenced
this pull request
Sep 20, 2024
**JIRA:** https://champlainsaintlambert.atlassian.net/browse/CPC-1134 Currently, users can access every page that the axiosErrorResponseHandler doesn't handle. This means that an admin or vet is able to access the customer profile edit page which only a customer should be able to see. Absolutely not. I hope. - Created a hook to validate user roles (useHasRequiredRole.ts). Implemented it in the ProtectedRouteProps.tsx - Added the roles that are authorized to access ProfileEdit, AddingCustomer, and AllOwners. Other teams can implement it to their pages as well (see dev notes). - Created 4 additional functions that people can use in the UserContext.tsx - Refactored and reorganized the ProfileEdit.tsx. The update form is now a component in the newly created components folder in features/customers No change to the UI. Users will just be redirected to 403 Forbidden when they access pages they shouldn't see If you want to make a page accessible by roles, just take a look at router.tsx. Pages that trigger the axiosErrorResponseHandler will automatically redirect users to an error page. If you want to be consistent, then add roles to each page that would require it. Update Customer #622 Add Customer #632 Show all customers #634
hristoiv11
pushed a commit
that referenced
this pull request
Sep 21, 2024
**JIRA:** https://champlainsaintlambert.atlassian.net/browse/CPC-1134 Currently, users can access every page that the axiosErrorResponseHandler doesn't handle. This means that an admin or vet is able to access the customer profile edit page which only a customer should be able to see. Absolutely not. I hope. - Created a hook to validate user roles (useHasRequiredRole.ts). Implemented it in the ProtectedRouteProps.tsx - Added the roles that are authorized to access ProfileEdit, AddingCustomer, and AllOwners. Other teams can implement it to their pages as well (see dev notes). - Created 4 additional functions that people can use in the UserContext.tsx - Refactored and reorganized the ProfileEdit.tsx. The update form is now a component in the newly created components folder in features/customers No change to the UI. Users will just be redirected to 403 Forbidden when they access pages they shouldn't see If you want to make a page accessible by roles, just take a look at router.tsx. Pages that trigger the axiosErrorResponseHandler will automatically redirect users to an error page. If you want to be consistent, then add roles to each page that would require it. Update Customer #622 Add Customer #632 Show all customers #634
hristoiv11
pushed a commit
that referenced
this pull request
Sep 22, 2024
**JIRA:** https://champlainsaintlambert.atlassian.net/browse/CPC-1134 Currently, users can access every page that the axiosErrorResponseHandler doesn't handle. This means that an admin or vet is able to access the customer profile edit page which only a customer should be able to see. Absolutely not. I hope. - Created a hook to validate user roles (useHasRequiredRole.ts). Implemented it in the ProtectedRouteProps.tsx - Added the roles that are authorized to access ProfileEdit, AddingCustomer, and AllOwners. Other teams can implement it to their pages as well (see dev notes). - Created 4 additional functions that people can use in the UserContext.tsx - Refactored and reorganized the ProfileEdit.tsx. The update form is now a component in the newly created components folder in features/customers No change to the UI. Users will just be redirected to 403 Forbidden when they access pages they shouldn't see If you want to make a page accessible by roles, just take a look at router.tsx. Pages that trigger the axiosErrorResponseHandler will automatically redirect users to an error page. If you want to be consistent, then add roles to each page that would require it. Update Customer #622 Add Customer #632 Show all customers #634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://champlainsaintlambert.atlassian.net/browse/CPC-1075
Context:
Added a v2 endpoint for being able to add a customer (as an admin). Adding a web form to input customer details, following the "Customer Profile Edit" form created previously.
Changes
Before and After UI (Required for UI-impacting PRs)