You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Qodana fails, the build report is not packed and archived. This PR attempts to run the archive of build reports even if Qodana build fails. We would also want to include Jacoco coverage inside the PR comments.
Changes Github Workflows
Changes
Run archive step when Qodana succeeds or fails
Bot comments on PR with Jacoco Coverage result (if PR doesn't have any tests, only overall project coverage will be shown)
i would suggest changing it to a feature it was not a bug. It is normal that the task would not run if the build task has failed. It would only be a bug if you had a condition and that condition was true and it was not running
viktorkuts
changed the title
bug(CONF-CPC-1413): updated steps to run if failed
feat(CONF-CPC-1413): qodana improve coverage
Oct 18, 2024
Yes I've seen this action, however it uses XML and I wanted to try parsing HTML reports beforehand (didn't really work). I'll enable XML reports, seems to be simpler after experimenting, thanks.
There is a bug within jacoco-report action, which shows services not meeting the min-coverage as passing. 1.4 should have fixed this, however the feature where we need to use multiple reports is present in the latest release, 1.4 errors.
Here is the issue
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://champlainsaintlambert.atlassian.net/browse/CPC-1413
Context
When Qodana fails, the build report is not packed and archived. This PR attempts to run the archive of build reports even if Qodana build fails. We would also want to include Jacoco coverage inside the PR comments.
Changes Github Workflows
Changes