Skip to content

Merge branch 'main' into feat/BILL-CPC-933_Implement_Button_To_Calcul…

Sign in for the full log view
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / Qodana for JVM completed Oct 24, 2023 in 0s

374 new problems found by Qodana for JVM

Qodana for JVM

374 new problems were found

Inspection name Severity Problems
Unused import 🔶 Warning 103
Redundant character escape 🔶 Warning 85
Dangling Javadoc comment 🔶 Warning 15
Invalid YAML configuration 🔶 Warning 11
Integer multiplication or shift implicitly cast to 'long' 🔶 Warning 10
AutoCloseable used without 'try'-with-resources 🔶 Warning 6
Optional.get() is called without isPresent() check 🔶 Warning 6
Default annotation parameter value 🔶 Warning 5
Field can be local 🔶 Warning 5
Redundant local variable 🔶 Warning 5
Nullability and data flow problems 🔶 Warning 4
Deprecated API usage 🔶 Warning 4
Link specified as plain text 🔶 Warning 4
@NotNull/@Nullable problems 🔶 Warning 4
Spring Data repository method parameters errors 🔶 Warning 4
Unused assignment 🔶 Warning 4
Possibly blocking call in non-blocking context 🔶 Warning 3
Call to 'printStackTrace()' 🔶 Warning 3
'Optional' used as field or parameter type 🔶 Warning 2
Unused publisher 🔶 Warning 2
Redundant type cast 🔶 Warning 2
Redundant 'close()' 🔶 Warning 2
Calling 'subscribe' in "reactive" methods 🔶 Warning 1
Field may be 'final' 🔶 Warning 1
Lombok @Getter may be used 🔶 Warning 1
Mismatch in @PathVariable declarations and usages 🔶 Warning 1
Begin or end anchor in unexpected position 🔶 Warning 1
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 1
Unnecessary call to 'toString()' 🔶 Warning 1
Commented out code ◽️ Notice 35
Duplicated code fragment ◽️ Notice 19
Non recommended 'field' injections ◽️ Notice 19
Constant values ◽️ Notice 2
Mismatch in @PathVariable declarations and usages ◽️ Notice 1
Throw statement in Reactive operator ◽️ Notice 1
Regular expression can be simplified ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 23 in visits-service-new/src/main/java/com/petclinic/visits/visitsservicenew/DomainClientLayer/Mailing/MailServiceImpl.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

AutoCloseable used without 'try'-with-resources 

'ResponseBody' used without 'try'-with-resources statement

Check warning on line 25 in auth-service/src/main/java/com/petclinic/authservice/domainclientlayer/Mail/MailServiceImpl.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

AutoCloseable used without 'try'-with-resources 

'ResponseBody' used without 'try'-with-resources statement

Check warning on line 26 in auth-service/src/main/java/com/petclinic/authservice/domainclientlayer/Mail/MailServiceImpl.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

AutoCloseable used without 'try'-with-resources 

'ResponseBody' used without 'try'-with-resources statement

Check warning on line 24 in visits-service-new/src/main/java/com/petclinic/visits/visitsservicenew/DomainClientLayer/Mailing/MailServiceImpl.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

AutoCloseable used without 'try'-with-resources 

'ResponseBody' used without 'try'-with-resources statement

Check warning on line 23 in auth-service/src/main/java/com/petclinic/authservice/Util/Configuration/Security/CustomBasicAuthenticationEntryPoint.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

AutoCloseable used without 'try'-with-resources 

'LogStream' used without 'try'-with-resources statement

Check warning on line 24 in auth-service/src/main/java/com/petclinic/authservice/Util/Configuration/Security/CustomBasicAuthenticationEntryPoint.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

AutoCloseable used without 'try'-with-resources 

'LogStream' used without 'try'-with-resources statement

Check warning on line 58 in api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Security/Filters/RoleFilter.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Possibly blocking call in non-blocking context 

Possibly blocking call in non-blocking context could lead to thread starvation

Check warning on line 98 in api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Security/Filters/JwtTokenFilter.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Possibly blocking call in non-blocking context 

Possibly blocking call in non-blocking context could lead to thread starvation

Check warning on line 56 in api-gateway/src/main/java/com/petclinic/bffapigateway/utils/Security/Filters/IsUserFilter.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Possibly blocking call in non-blocking context 

Possibly blocking call in non-blocking context could lead to thread starvation

Check warning on line 93 in visits-service-new/src/main/java/com/petclinic/visits/visitsservicenew/BusinessLayer/VisitServiceImpl.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Calling 'subscribe' in "reactive" methods 

Calling 'subscribe' in non-blocking context is not recommended

Check notice on line 61 in customers-service-reactive/src/main/java/com/petclinic/customersservice/business/PetTypeServiceImpl.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (6 lines)

Check notice on line 153 in api-gateway/src/main/java/com/petclinic/bffapigateway/domainclientlayer/CustomersServiceClient.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (8 lines)

Check notice on line 287 in api-gateway/src/main/java/com/petclinic/bffapigateway/presentationlayer/BFFApiGatewayController.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (33 lines)

Check notice on line 635 in api-gateway/src/main/java/com/petclinic/bffapigateway/presentationlayer/BFFApiGatewayController.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (6 lines)

Check notice on line 95 in visits-service-new/src/main/java/com/petclinic/visits/visitsservicenew/BusinessLayer/VisitServiceImpl.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (4 lines)

Check notice on line 21 in visits-service-new/src/main/java/com/petclinic/visits/visitsservicenew/BusinessLayer/VisitService.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (2 lines)

Check notice on line 545 in api-gateway/src/main/java/com/petclinic/bffapigateway/presentationlayer/BFFApiGatewayController.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (16 lines)

Check notice on line 10 in api-gateway/src/main/java/com/petclinic/bffapigateway/exceptions/InvalidInputException.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (3 lines)

Check notice on line 18 in billing-service/src/main/java/com/petclinic/billing/businesslayer/BillServiceImpl.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (2 lines)

Check notice on line 113 in auth-service/src/main/java/com/petclinic/authservice/businesslayer/UserServiceImpl.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (6 lines)

Check notice on line 1 in billing-service/src/main/java/com/petclinic/billing/domainclientlayer/VetClient.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (32 lines)

Check notice on line 200 in api-gateway/src/main/java/com/petclinic/bffapigateway/domainclientlayer/AuthServiceClient.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (12 lines)

Check notice on line 80 in visits-service-new/src/main/java/com/petclinic/visits/visitsservicenew/PresentationLayer/VisitController.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (9 lines)

Check notice on line 161 in api-gateway/src/main/java/com/petclinic/bffapigateway/presentationlayer/BFFApiGatewayController.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (4 lines)

Check notice on line 151 in api-gateway/src/main/java/com/petclinic/bffapigateway/domainclientlayer/VisitsServiceClient.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (17 lines)
View more details on GitHub Actions