Fix numpy-test to work across python 3.12 to 3.13 transition. #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing because 'numpy' is now installing a python3.13 version. Instead of making an assumption on what it installs, let the pipeline do the rigth thing. The python/import pipeline will search for exactly one python installed and use it to test the import.
smoser
force-pushed
the
fix/e2e-numpy-test
branch
from
1807fb4 to
3a16441
Compare
89luca89
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing because 'numpy' is now installing a python3.13 version. Instead of making an assumption on what it installs, let the pipeline do the rigth thing.
The python/import pipeline will search for exactly one python installed and use it to test the import.