Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ca-certificates-bundle to cargo/build pipeline #1729

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kranurag7
Copy link
Contributor

@kranurag7 kranurag7 commented Jan 5, 2025

add ca-certificates-bundle to cargo/build pipeline

similar to our go/build pipeline, this commit adds
ca-certificates-bundle to cargo/build pipeline.

this is required because sometimes cargo cannot connect to github.com
directly. In cases where cargo cannot connect to github.com, we get the
following error message:

Stderr: fatal: unable to access
'https://github.com/the-mikedavis/tree-sitter-git-commit/': Failed to
connect to github.com port 443 after 131793 ms: Could not connect to
server

this is happening because we don't have ca-certificates-bundle at
build-time. Adding ca-certificates-bundle fixes the same.

Signed-off-by: kranurag7 <[email protected]>

referencing pr where this is happening and which lead to this patch: wolfi-dev/os#38735

Melange Pull Request Template

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

similar to our go/build pipeline, this commit adds
ca-certificates-bundle to cargo/build pipeline.

this is required because sometimes cargo cannot connect to github.com
directly. In cases where cargo cannot connect to github.com, we get the
following error message:

Stderr: fatal: unable to access
'https://github.com/the-mikedavis/tree-sitter-git-commit/': Failed to
connect to github.com port 443 after 131793 ms: Could not connect to
server

this is happening because we don't have ca-certificates-bundle at
build-time. Adding ca-certificates-bundle fixes the same.

Signed-off-by: kranurag7 <[email protected]>
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is needed. Discussing offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants