melange bump: only reset the epoch if version changes, else increment it #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjohnsonjr
reviewed
Oct 7, 2023
This can happen when an upstream deletes a tag and re-uses it with a different commit, so we need to bump the epoch rather than reset it. If there are no version or expected commit changes we still expect the epoch to be bumped Signed-off-by: James Rawlings <[email protected]>
Signed-off-by: James Rawlings <[email protected]>
rawlingsj
added a commit
to wolfi-dev/os
that referenced
this pull request
Oct 17, 2023
Manually bump epoch as seems upstream has recreated the version tag and the bot is not yet automating the bump. Until chainguard-dev/melange#733 is merged we need to manually bump it. Signed-off-by: James Rawlings <[email protected]>
rawlingsj
added a commit
to wolfi-dev/os
that referenced
this pull request
Oct 17, 2023
We need to manually bump the epoch until this is merged and available in wolfi chainguard-dev/melange#733 Signed-off-by: James Rawlings <[email protected]>
rawlingsj
added a commit
to wolfi-dev/os
that referenced
this pull request
Oct 17, 2023
We need to manually bump the epoch until this is merged and available in wolfi chainguard-dev/melange#733 Signed-off-by: James Rawlings <[email protected]>
mattmoor
approved these changes
Oct 25, 2023
rawlingsj
added a commit
to wolfi-dev/os
that referenced
this pull request
Oct 30, 2023
… to roll out into wolfi ma Signed-off-by: James Rawlings <[email protected]>
rawlingsj
added a commit
to rawlingsj/wolfictl
that referenced
this pull request
Oct 30, 2023
related chainguard-dev/melange#733 Signed-off-by: James Rawlings <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen when an upstream deletes a tag and re-uses it with a different commit, so we need to bump the epoch rather than reset it. Example wolfi-dev/os@4a7ae40
If there are no version or expected commit changes we still expect the epoch to be bumped