simplify --fail-on-lint-warning and fix error message #747
Conversation
Signed-off-by: Jason Hall <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
imjasonh
force-pushed
the
lint-multierr
branch
from
adaab4b to
86fbc5d
Compare
| if linter.FailOnError { | ||
| return fmt.Errorf("Linter %s failed; suggest: %s", linterName, linter.Explain) | ||
| } | ||
| warn(err) |
There was a problem hiding this comment.
This eliminates the ability to have individual linters be fatal.
There was a problem hiding this comment.
Basically: we need a way to introduce a linter as just a warning, get it clean, and then make it fatal.
If we land this then we can't make anything required without making everything required and it will become a requirement to get linters clean across Wolfi before landing any of its logic, which I don't think we want.
There was a problem hiding this comment.
WDYT about having --fail-on-lint-warning=empty,setuidgid,foo,bar which selects which ones will be considered fatal?
There was a problem hiding this comment.
That seems fine, but I still think linters should be able to have defaults. This could be through the flag defaults, I have no preference here.
This uses
errors.Jointo collect multiple lint findings and report on them (or not) all at once, instead of failing on the first one when there may be more to find.This also removes the
warncallback pattern and just hasLintPackageFsreturn anyJoined errors, ornilif none are found. In this change,BuildPackageis responsible for erroring or warning when lint errors are found, instead of burying that deep insideLintPackageFs.This PR originally started as an attempt to fix a malformed error output when linting produced errors: