Add multiple Python packages post-linter #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elizabeth Myers <[email protected]>
Signed-off-by: Elizabeth Myers <[email protected]>
Elizafox
force-pushed
the
python-multiple-postlint
branch
from
f9bcbb7 to
2f4374d
Compare
Signed-off-by: Elizabeth Myers <[email protected]>
Signed-off-by: Elizabeth Myers <[email protected]>
Elizafox
force-pushed
the
python-multiple-postlint
branch
from
30c5833 to
4e3cd34
Compare
This will be caught by a different linter later Signed-off-by: Elizabeth Myers <[email protected]>
This will be caught by another linter later. Signed-off-by: Elizabeth Myers <[email protected]>
Elizafox
changed the title
Signed-off-by: Elizabeth Myers <[email protected]>
imjasonh
reviewed
Oct 23, 2023
|
The change itself looks good. Do we have data about how many existing latest packages might get tripped up by this? |
Doing a run on all py3 packages, will report back when it's done. |
|
Here are the failures I collected from our built APK's: https://gist.github.com/Elizafox/8046fd4a06e8cfd309ee9dac84ebe11d Some of those are false positives, like _foo packages. I might disregard them. Others the linter should be disabled on. This will probably remain a warning-only linter for the forseeable future. |
These are generally internal packages in Python and should be ignored as duplicates. Signed-off-by: Elizabeth Myers <[email protected]>
Strip off the extension and add them to a map, to filter them as duplicates. Signed-off-by: Elizabeth Myers <[email protected]>
Signed-off-by: Elizabeth Myers <[email protected]>
Elizafox
changed the title
|
That gist is really helpful!! Thanks for adding this, let's get it into use. |
imjasonh
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take two after resolving git issues.
This implements a lint checking if a package contains multiple Python packages.
It's rather simplistic at the moment but I think this should get the job done.
Linter