Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ownership issue #784

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

epsilon-phase
Copy link
Contributor

Fix permission issues resulting from running with the build user under Docker. and make the GID/UID remapping work to correct that.

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:
I have not tried

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:
I have not tried

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

Elizafox
Elizafox previously approved these changes Oct 25, 2023
Elizafox
Elizafox previously approved these changes Oct 26, 2023
@epsilon-phase epsilon-phase force-pushed the melange-permission-fix branch 2 times, most recently from 1a9940d to 5407eee Compare October 26, 2023 19:06
Elizafox
Elizafox previously approved these changes Oct 26, 2023
@epsilon-phase epsilon-phase force-pushed the melange-permission-fix branch 9 times, most recently from 69fcc31 to 88ad33a Compare October 26, 2023 20:12
Fix permission issues resulting from running with the build user.

Signed-off-by: Violet White <[email protected]>
@epsilon-phase epsilon-phase force-pushed the melange-permission-fix branch 2 times, most recently from e5abc94 to 85b70bf Compare October 27, 2023 18:03
@Elizafox
Copy link
Contributor

Thank you so much @epsilon-phase :) you have done great work. I'm sorry this was such an awful drag of a task. 🎉

@epsilon-phase epsilon-phase marked this pull request as ready for review October 27, 2023 18:35
@Elizafox Elizafox merged commit a99c211 into chainguard-dev:main Oct 27, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants