Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: track gain and mdoc files alongside runs #280
feat: track gain and mdoc files alongside runs #280
Changes from 4 commits
368878a
3577464
bab2e7e
011f0e4
c18827a
385404b
78fec97
51cd026
c3496d7
6415b70
c428c8d
ca6612e
f38cfaf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in_plane_rotation
field will be a collection of 4 float values. Should we make it a vector or a string?beam_tilt
field is not going to be supported for now.is_canonical
boolean field and the floatvolume_x_rotation
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supporting vectors and other strongly typed json fields is pretty doable in the API - we already support 2d arays of floats, so supporting 1d arrays is easy to add. I haven't tried to add complex types to the client before though, so that could get interesting. Do you think
in_plane_rotation
would be best represented as a list of floats?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uermel Could we have your thoughts on what is the best way to represent
in_plane_rotation
for the end user?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decision: This will be a 2d rotation matrix, basically
list[list[float]]