feat: add frame & gain ingestion to db import #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgadling
commented
Oct 10, 2024
| logger = logging.getLogger("config") | ||
|
|
||
|
|
||
| class DBImportConfig: |
There was a problem hiding this comment.
I moved this class out of importers/base_importer.py into its own file.
jgadling
commented
Oct 10, 2024
| pass | ||
|
|
||
|
|
||
| class FileFinder(ItemFinder): |
There was a problem hiding this comment.
We'll need to add more finders over time, but this is ~similar to the idea of finders in s3 ingestion.
jgadling
commented
Oct 10, 2024
Comment on lines
+58
to
+59
| if prefix.startswith("s3://"): | ||
| prefix = "/".join(prefix.split("/")[3:]) |
There was a problem hiding this comment.
I added these two lines to this method to make it a little less fussy to work with.
manasaV3
approved these changes
Oct 14, 2024
Comment on lines
+29
to
+30
| self.model_args["run_id"] = self.input_data["run"].id | ||
| self.model_args["deposition_id"] = self.input_data["deposition"].id |
There was a problem hiding this comment.
We currently don't have a metadata for this, so would we populating this from the dataset's deposition_id ?
* Remove deprecated `Tomogram.is_standardized field`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also started working on a new interface for these db importers that more closely resembles the S3 importers, so hopefully they're easier to maintain going forward. I'll update the old importers to use the new base classes over the next few weeks.