Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updating alignment dimensions and offsets to Angstrom #323

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix: Updating alignment dimensions and offsets to Angstrom #323

merged 2 commits into from
Oct 16, 2024

Conversation

manasaV3
Copy link
Contributor

Relates to

Description

this is necessary because tomograms of different voxel spacings should be able to have the same alignment.
so we have to specify the size independent of voxel spacing

@manasaV3 manasaV3 requested review from uermel and jgadling October 16, 2024 19:18
uermel
uermel requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@uermel uermel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voxel size needs to be multiplied by the dimension.

ingestion_tools/scripts/importers/alignment.py Outdated Show resolved Hide resolved
uermel
uermel approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@uermel uermel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@manasaV3 manasaV3 merged commit e4a74a2 into main Oct 16, 2024
7 checks passed
@manasaV3 manasaV3 deleted the mvenkatakrishnan/update_algn branch October 16, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uermel uermel uermel approved these changes

@jgadling jgadling jgadling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manasaV3 @jgadling @uermel