Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Updating long execution name generation #408

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Updating long execution name generation #408

wants to merge 2 commits into from
+5 −3

Conversation

manasaV3
Copy link
Contributor

Relates to ~

Description

Ais deposition ingestion and one issue I'm running into is that I can't enqueue certain jobs because the name truncation here leads to jobs having the same name when I want to re-run them, i.e. I get a botocore.errorfactory.ExecutionAlreadyExists exception. Also, this exception is occuring silently because enqueue_runs doesn't check the result of the concurrent futures.

Addresses the issue mentioned above.

@manasaV3 manasaV3 requested review from uermel and jgadling January 10, 2025 23:17
uermel
uermel approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@uermel uermel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and thanks for fixing the DB test as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uermel uermel uermel approved these changes

@jgadling jgadling Awaiting requested review from jgadling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manasaV3 @uermel