feat: preview label deployments #1413
Conversation
|
Yes! Thank you! |
| const event = ${{ toJson(github.event) }} | ||
| const eventName = '${{ github.event_name }}' | ||
|
|
||
| let name = '' |
There was a problem hiding this comment.
is this necessary? does using the branch name not work?
There was a problem hiding this comment.
let me check, I think it's because the ref is different depending on the event but maybe we can use event.ref for both 🤔
There was a problem hiding this comment.
actually yeah this is required, we can only get the ref name for the PR from the pull request event object. using something like github.ref will only return the PR number:
I did a test run here and you can see it doesn't include the ref name in the last value. instead, it shows up as 1428/merge:
.github/workflows/dev-deploy.yml
Outdated
| github.event_name == 'pull_request' && ( | ||
| github.event.action == 'labeled' || ( | ||
| github.event.action == 'synchronize' && | ||
| contains(github.event.pull_request.labels.*.name, 'preview') |
There was a problem hiding this comment.
is this the only thing you need to check? this whole condition only has to be a subset of the condition at the job level right?
There was a problem hiding this comment.
I think the main thing is we only want this to run when:
- it's a push to
dev-* - the PR is labeled
- the PR is updated
we actually do check if preview exists before executing the job here:
so maybe we can remove this since it's already checked. if the event is synchronize, then it should have the preview label since the above condition passed 🤣
let me check and see if it works as expected without this
There was a problem hiding this comment.
just checked, yeah this can be removed. thank you for catching this!! 🔥
|
|
||
| https://${{ steps.deploy-data.outputs.result }}.cryoet.dev.si.czi.technology | ||
|
|
||
| Updated: ${{ steps.get-comment-date.outputs.result }} PST |
Adds the ability to create preview deployments from an existing PR by adding a
previewlabel to the PR. This works by updating thedev-deploy.ymlso that:previewlabel creates a new preview deployment and posts a comment on the PR with the URL and last updated datepreviewlabel takes down preview deployment and deletes the PR commentChanges to existing workflow
dev-*should still work as expectedDemo
PR comment
Create preview on label
https://github.com/chanzuckerberg/cryoet-data-portal/actions/runs/12418548047
Delete preview on label
https://github.com/chanzuckerberg/cryoet-data-portal/actions/runs/12405421842
Delete preview on close
https://github.com/chanzuckerberg/cryoet-data-portal/actions/runs/12421062766