Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add deposition to V2 run query #1424

Merged
merged 5 commits into from
Dec 23, 2024
Merged

feat: Add deposition to V2 run query #1424

merged 5 commits into from
Dec 23, 2024

Conversation

bchu1
Copy link
Contributor

@bchu1 bchu1 commented Dec 23, 2024

No description provided.

Copy link
Member

@kne42 kne42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

client: apolloClient,
params: url.searchParams,
}),
getRunByIdV2(apolloClientV2, id, annotationsPage, url.searchParams),
getRunByIdV2(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated nit but would be nice if we used keyword params here so it's more clear what things are for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants