feat: add update method to update configs from other models
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NucciTheBoss
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Nice work on this. Having proper update functionality for the data models will be super helpful for writing good, clean code.
I just a few comments around the implementation. In it's current form, we'll encounter some semantic issues, especially with the Node, FrontendNode, Partitions, etc data models. Let me know if you have any questions; our discussion here will help make slurmutils more robust!
jedel1043
changed the title
override method to combine configsupdate method to update configs from other models
NucciTheBoss
requested changes
Aug 29, 2024
Rename override to update so that the `update` method is properly overrided in inheriting data models.
Use current `slurmutils` terminology in docstring
NucciTheBoss
added
the
Type: Enhancement
NucciTheBoss
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Nice work on this @jedel1043 🚀
Great to see slurmutils maturing like it is!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it really easy to change a set of configs without having to set the properties one by one.