Data/op reviewer info export #5049
Conversation
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 suggestion.
Comments skipped due to low confidence (1)
scripts/optimism/getProposalReviewerStats.ts:113
- The variable name 'intakeStap' is a typo. It should be renamed to 'intakeStep'.
let intakeStap: ProposalStep | undefined;
| @@ -0,0 +1,8 @@ | |||
| export default { | |||
| // Teardown function after all tests run | |||
|
|
||
| export function getUniqueWeeksCount(events: Date[]): number { | ||
| // Helper function to calculate the ISO week number | ||
| function getWeekNumber(date: Date): number { |
There was a problem hiding this comment.
Strongly prefer we do not write/maintain our own date logic and use libs instead. This code is extremely hard to follow
You should be able to just do DateTime.fromJSDate(date).weekYear
https://moment.github.io/luxon/api-docs/index.html#datetimeweeknumber
There was a problem hiding this comment.
Would be better if you used a date library instead of AI to do date math (I'm assuming that method was generated :). I think I wouldn't even point it out if it was part of the single-use script, but when it lives in the utils package it means it can be used anywhere, and we should always default to using luxon in our production code
…ata/op-reviewer-info-export
…ata/op-reviewer-info-export
WHAT
WHY