Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quests for both apps #5099

Merged
merged 28 commits into from
Dec 9, 2024
Merged

Quests for both apps #5099

merged 28 commits into from
Dec 9, 2024

Conversation

valentinludu
Copy link
Collaborator

No description provided.

@valentinludu valentinludu changed the title Quests for both apps Quests for both apps - WIP Dec 4, 2024
@valentinludu valentinludu changed the title Quests for both apps - WIP Quests for both apps Dec 5, 2024
@Devorein Devorein self-requested a review December 6, 2024 12:35
Copy link
Member

@Devorein Devorein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great everything seems to be working like before. A few small design changes are required.

image
  1. The typography color seems to be using primary color rather than white
  2. The width of the Quests section should be narrower according to the mockup
  3. Clicking on quests when logged out should show a different modal like claim page
  4. Scrollbar even when its not required

@valentinludu valentinludu requested a review from Devorein December 6, 2024 18:39
Copy link
Member

@mattcasey mattcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@valentinludu valentinludu merged commit 9aeaa86 into main Dec 9, 2024
73 checks passed
@valentinludu valentinludu deleted the feat/sg-quests branch December 9, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants