Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimism proposal reviewer notifications #5153

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Optimism proposal reviewer notifications #5153

merged 5 commits into from
Jan 17, 2025

Conversation

Devorein
Copy link
Member

WHAT

WHY

motechFR
motechFR reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@motechFR motechFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would work as is, but I think we should optimise the query

mattcasey
mattcasey requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@mattcasey mattcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

mattcasey
mattcasey reviewed Jan 17, 2025
View reviewed changes
lib/notifications/documents/createDocumentNotifications.ts Outdated
)
).filter((userId) => userId !== commentAuthorId && !notificationSentUserIds.has(userId));

if (documentId && proposalId && space.domain === 'op-grants' && proposalReviewerUserIds.length) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove check for op-grants

@Devorein Devorein merged commit dc7ac73 into main Jan 17, 2025
7 checks passed
@Devorein Devorein deleted the feat/op-proposal-notifications branch January 17, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motechFR motechFR motechFR left review comments

@mattcasey mattcasey mattcasey requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Devorein @mattcasey @motechFR