Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and added improved inertia alignment #122

Merged
merged 44 commits into from
Jan 9, 2025
Merged

Conversation

charnley
Copy link
Owner

@charnley charnley commented Jan 4, 2025

No description provided.

Copy link
Contributor

@hagenmuenkler hagenmuenkler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I like the new readme, nicely written. I left a comment on the get_inertia_tensor function, where there is still some conflict of old and new code.
For that method, I would also put in the docstring that in calculates the inertia tensor around the center of mass. This is what everybody does anyway, but in principle you can calculate the inertia tensor around a different point.
In the readme, I'm missing an explanation that a full calculation (brute-force) of the minimal RMSD is possible (figure out all ways to match the mols, calculate optimal rotations for each); and that this is implemented in rdkit. So the point is probably to provide something that is much faster (especially for larger molecules) and still a good approximation.

rmsd/calculate_rmsd.py Outdated Show resolved Hide resolved
@charnley charnley merged commit 21cc9af into master Jan 9, 2025
10 checks passed
@charnley charnley deleted the charnley/doc branch January 9, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants