cody/cap 5162 pnpm workspace aliases lose identity in the dependency graph - #1507
Closed
Conversation
codykaup
added this pull request to stack #1506
September 25, 2026 20:00
Contributor
|
📦 Package Size: 5900 KB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cody/cap-5161-pnpm-12-multi-document-pnpm-lockyaml-fails-to-parse-so #1507 +/- ##
========================================================================================================
+ Coverage 86.91% 86.93% +0.01%
========================================================================================================
Files 274 274
Lines 5512 5517 +5
Branches 1497 1495 -2
========================================================================================================
+ Hits 4791 4796 +5
Misses 635 635
Partials 86 86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
A `link:` dependency is resolved through the parser's project map, which only held the importer being parsed. Every link fell back to the version 'undefined', so pointing an alias such as `theme: workspace:red@*` at another workspace package produced the same graph node and TurboSnap saw no change. Seed the map with every importer, using the importer path as the version. The target's real version would not tell two packages at the same version apart, and the path needs nothing read from the target's manifest at HEAD or the baseline.
codykaup
force-pushed
the
cody/cap-5162-pnpm-workspace-aliases-lose-identity-in-the-dependency-graph
branch
from
September 28, 2026 15:44
d7e4508 to
1014591
Compare
Contributor
Author
|
So I'm not sure if this case is going to get hit or not. I'm going to close it until we see cases like this in the real world. |
An error occurred while trying to automatically change base from
cody/cap-5161-pnpm-12-multi-document-pnpm-lockyaml-fails-to-parse-so
to
main
September 28, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬
📦 Published PR as canary version:
18.9.7--canary.1507.36445907741.0✨ Test out this PR locally via:
npm install chromatic@18.9.7--canary.1507.36445907741.0 # or yarn add chromatic@18.9.7--canary.1507.36445907741.0