Various fixes and updates... #1
Conversation
…ic, localhost in connect address...
| @@ -9,7 +9,7 @@ | |||
| "express": "^4.16.3", | |||
| "jquery-min": "0.0.2", | |||
| "log-timestamp": "^0.1.2", | |||
| "pty": "0.0.0", | |||
| "node-pty": "^0.7.6", | |||
There was a problem hiding this comment.
I don't know which version of node you're running, but it appears that pty.js is not updated for more recent versions. I'm running v10.0.0. It appears that node-pty is a suitable update so I've made the change (this fixed problems).
| const path = require('path'); | ||
|
|
||
| const Docker = require('dockerode'); | ||
| const docker = new Docker(); |
There was a problem hiding this comment.
Removed unused imports, swap pty.js for node-pty.
|
|
||
| // Creating an HTTP server | ||
| var server = http.createServer(app).listen(8080) | ||
| const server = http.createServer(app).listen(7171); |
There was a problem hiding this comment.
I changed port 8080 to 7171 simply because 8080 is used in many other projects, so this new port will hopefully avoid collisions with other projects the user wants to run on localhost (this happened to me, I typically will run a database API or the frontend of the app I'm building, on 8080, which is the thing I want to target with fake traffic).
|
|
||
| ``` | ||
| Node.js | ||
| Docker | ||
| $ docker pull trexcisco/trex-dev:2.36 |
There was a problem hiding this comment.
People may not realize they need to pull the docker image, and specifically trexcisco/trex-dev:2.36 in this case.
| }); | ||
| } | ||
|
|
||
|
|
||
| function create_socket() { | ||
| // Connect to the socket.io server | ||
| client.socket = io.connect('http://csi-trex-10:8080'); | ||
| client.socket = io.connect('http://localhost:7171'); |
There was a problem hiding this comment.
124: I assume you are using csi-trex-10 for localhost, this will trip some people up. Could alternatively put 127.0.0.1 here.
| } | ||
|
|
||
| function on_window_resize() { | ||
| cols, rows = get_console_size(); | ||
| const { cols, rows } = get_console_size(); |
There was a problem hiding this comment.
Seems curly braces for destructuring are missing here. Also const is needed to prevent these from being assigned globally.
|
|
||
| </body> | ||
| <!-- <body onresize="on_window_resize()"></body> --> | ||
| <body></body> |
There was a problem hiding this comment.
(I only tested in Chrome)
The on_window_resize process was already broken, but after fixing it, the experience in the frontend is actually worse, so I've commented out the resize function until I understand what the original intent was. Commenting out this resize function makes the frontend more usable.
For me, on_window_resize causes all content in the consoles to be reduced to just one character.
| cols: cols, | ||
| rows: rows, | ||
| cols, | ||
| rows, |
There was a problem hiding this comment.
Might as well use short-hand syntax for these object properties.
| cols: cols, | ||
| rows: rows, | ||
| cols, | ||
| rows, |
There was a problem hiding this comment.
Might as well use short-hand syntax for these object properties.
| cols: dim.cols, | ||
| rows: dim.rows, | ||
| cols, | ||
| rows, |
There was a problem hiding this comment.
Might as well use short-hand syntax for these object properties.
What I've Done
I will add code comments for all of the changes which are more localized.
varwere replaced with appropriateconstorlet.Outstanding Issues
Not all issues are fixed by this PR.
server.jscurrently references two files which don't seem to exist in the container and I don't know what the fix is yet. These are the offending references:Additionally,
/etc/startup.shgives me errors:I haven't investigated this error yet. I think it would help to know the original intent behind
code.shandtcpdump, as mentioned.What Next
I'd like to get this project fully working before focusing on improvements. I think a react frontend would be a significant improvement over jquery, and wouldn't need to over-complicate the project. This is something I'd like to do, both for my own uses and to help others grok the app.
I don't yet have enough familiarity with TRex – can it simulate traffic through authenticated endpoints? Meaning, register -> login -> browse. Could we add an interface for generating traffic of this sort? Is this already easy to do?
Should this project instead by using
https://hub.docker.com/r/trexcisco/trex/?I'd like to add tests.
Thanks for constructing this example.