Adds postgres 15 support for docker #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurkanindibay
commented
Oct 17, 2022
| @@ -24,6 +24,8 @@ RUN apk add --no-cache \ | |||
| llvm \ | |||
| lz4-dev \ | |||
| zstd-dev \ | |||
| libxslt-dev \ | |||
| libxml2-dev \ | |||
There was a problem hiding this comment.
This was not directly related to pg 15 changes but we recently added these two lines since new alpine images does not have these packages
onurctirtir
reviewed
Oct 17, 2022
| @@ -1,5 +1,5 @@ | |||
| # This file is auto generated from it's template, | |||
| # see citusdata/tools/packaging_automation/templates/docker/postgres-12/postgres-12.tmpl.dockerfile. | |||
| # see citusdata/tools/packaging_automation/templates/docker/postgres-13/postgres-13.tmpl.dockerfile. | |||
There was a problem hiding this comment.
but the filename is based on pg13 ?
| @@ -1,53 +0,0 @@ | |||
| name: Citus package all platforms beta tests | |||
There was a problem hiding this comment.
can you share the failing test run that makes us removing this file ?
There was a problem hiding this comment.
onurctirtir
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to remove beta tests since my test tag v10.2.4_beta was removed. I tried to update my tests but it took too much time. Therefore I opened a task for it and will handle afterwards
#253