Repository navigation
Ignore received PTR and local DNS records - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A feed line such as
7.100.51.198.in-addr.arpa. 300 IN PTR target.example.could add both names to a blocklist. The parser now skips PTR records as a whole, filters local and reverse-zone names, and skips DNS records that point to local addresses or local aliases.Forward enrichment accepts only the requested A or AAAA record type and ignores answers with a local canonical name. Existing local-IP filtering still applies to returned addresses.
All 39 unit tests passed. Regression coverage includes feed records, additional PTR records in a DNS response, and a forward lookup that follows a CNAME into
.local.