Migrate from tslint to eslint #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, looks like I'm missing one piece, ignore this for now till I address that piece |
|
Alright, I think things are good to go! I had to fix some things from the typescript update but everything seems to be working based on my tests. Let me know if any changes are needed or if things need to be broken down even more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tslint is depreciated so this push implements eslint following the steps highlighted here! This will close #149 but there is further work needed to resolve all warnings.
All changes are tested, and you can run the lint with
npm run lintor using the associated vscode task.Besides the migration changes, I had to update the typescript version because we were way behind and it didn't work with eslint